| Message ID | 1413131033-26185-1-git-send-email-maxime.hadjinlian@gmail.com |
|---|---|
| State | Accepted |
| Commit | 71787e9d3538efcb561f780529fe395f0ca747dd |
| Headers | show |
Dear Maxime Hadjinlian, On Sun, 12 Oct 2014 18:23:53 +0200, Maxime Hadjinlian wrote: > Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com> > --- > package/luaposix/luaposix.mk | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/package/luaposix/luaposix.mk b/package/luaposix/luaposix.mk > index 46723a0..13fc266 100644 > --- a/package/luaposix/luaposix.mk > +++ b/package/luaposix/luaposix.mk > @@ -5,8 +5,7 @@ > ################################################################################ > > LUAPOSIX_VERSION = 32 > -LUAPOSIX_SITE = https://github.com/luaposix/luaposix/archive > -LUAPOSIX_SOURCE = release-v$(LUAPOSIX_VERSION).tar.gz > +LUAPOSIX_SITE = $(call github,luaposix,luaposix,release-v$(LUAPOSIX_VERSION)) > LUAPOSIX_LICENSE = MIT > LUAPOSIX_LICENSE_FILES = COPYING > LUAPOSIX_DEPENDENCIES = luainterpreter host-lua Why would we want to use git instead of a simple tarball? Thomas
On Sun, Oct 12, 2014 at 6:29 PM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Dear Maxime Hadjinlian, > > On Sun, 12 Oct 2014 18:23:53 +0200, Maxime Hadjinlian wrote: >> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com> >> --- >> package/luaposix/luaposix.mk | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/package/luaposix/luaposix.mk b/package/luaposix/luaposix.mk >> index 46723a0..13fc266 100644 >> --- a/package/luaposix/luaposix.mk >> +++ b/package/luaposix/luaposix.mk >> @@ -5,8 +5,7 @@ >> ################################################################################ >> >> LUAPOSIX_VERSION = 32 >> -LUAPOSIX_SITE = https://github.com/luaposix/luaposix/archive >> -LUAPOSIX_SOURCE = release-v$(LUAPOSIX_VERSION).tar.gz >> +LUAPOSIX_SITE = $(call github,luaposix,luaposix,release-v$(LUAPOSIX_VERSION)) >> LUAPOSIX_LICENSE = MIT >> LUAPOSIX_LICENSE_FILES = COPYING >> LUAPOSIX_DEPENDENCIES = luainterpreter host-lua > > Why would we want to use git instead of a simple tarball? We are using the tarball, they both came from the space place. Only we are using the github helper call, which shield us from any change on github part. > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com
Maxime, All, On 2014-10-12 18:23 +0200, Maxime Hadjinlian spake thusly: > Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Regards, Yann E. MORIN. > --- > package/luaposix/luaposix.mk | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/package/luaposix/luaposix.mk b/package/luaposix/luaposix.mk > index 46723a0..13fc266 100644 > --- a/package/luaposix/luaposix.mk > +++ b/package/luaposix/luaposix.mk > @@ -5,8 +5,7 @@ > ################################################################################ > > LUAPOSIX_VERSION = 32 > -LUAPOSIX_SITE = https://github.com/luaposix/luaposix/archive > -LUAPOSIX_SOURCE = release-v$(LUAPOSIX_VERSION).tar.gz > +LUAPOSIX_SITE = $(call github,luaposix,luaposix,release-v$(LUAPOSIX_VERSION)) > LUAPOSIX_LICENSE = MIT > LUAPOSIX_LICENSE_FILES = COPYING > LUAPOSIX_DEPENDENCIES = luainterpreter host-lua > -- > 2.1.1 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
>>>>> "Maxime" == Maxime Hadjinlian <maxime.hadjinlian@gmail.com> writes: > Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com> Committed, thanks.
diff --git a/package/luaposix/luaposix.mk b/package/luaposix/luaposix.mk index 46723a0..13fc266 100644 --- a/package/luaposix/luaposix.mk +++ b/package/luaposix/luaposix.mk @@ -5,8 +5,7 @@ ################################################################################ LUAPOSIX_VERSION = 32 -LUAPOSIX_SITE = https://github.com/luaposix/luaposix/archive -LUAPOSIX_SOURCE = release-v$(LUAPOSIX_VERSION).tar.gz +LUAPOSIX_SITE = $(call github,luaposix,luaposix,release-v$(LUAPOSIX_VERSION)) LUAPOSIX_LICENSE = MIT LUAPOSIX_LICENSE_FILES = COPYING LUAPOSIX_DEPENDENCIES = luainterpreter host-lua
Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com> --- package/luaposix/luaposix.mk | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)