| Message ID | 1396254432-22594-1-git-send-email-maxime.hadjinlian@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
Maxime Hadjinlian <maxime.hadjinlian@gmail.com> wrote in news:1396254432-22594-1-git-send-email-maxime.hadjinlian@gmail.com: > - select BR2_HOST_NEEDS_JAVA > + select BR2_NEEDS_HOST_JAVA Acked-by: Bernd Kuhls <bernd.kuhls@t-online.de>
Dear Maxime Hadjinlian, On Mon, 31 Mar 2014 10:27:12 +0200, Maxime Hadjinlian wrote: > A check for Java has been implemented in dependencies.sh, but during the > review, the name of the variable had been changed from: > BR2_HOST_NEEDS_JAVA to BR2_NEEDS_HOST_JAVA > as it is more accurate. > > The change was not made in XBMC and as such, you could start the build > of XBMC without Java on your system. > > Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com> > --- > package/xbmc/Config.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. Thomas
diff --git a/package/xbmc/Config.in b/package/xbmc/Config.in index e078d2f..cf6a6b9 100644 --- a/package/xbmc/Config.in +++ b/package/xbmc/Config.in @@ -9,7 +9,7 @@ comment "xbmc requires an OpenGL ES and EGL backend" menuconfig BR2_PACKAGE_XBMC bool "xbmc" - select BR2_HOST_NEEDS_JAVA + select BR2_NEEDS_HOST_JAVA select BR2_PACKAGE_BOOST select BR2_PACKAGE_BOOST_THREAD select BR2_PACKAGE_BZIP2
A check for Java has been implemented in dependencies.sh, but during the review, the name of the variable had been changed from: BR2_HOST_NEEDS_JAVA to BR2_NEEDS_HOST_JAVA as it is more accurate. The change was not made in XBMC and as such, you could start the build of XBMC without Java on your system. Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com> --- package/xbmc/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)