| Message ID | 1393100684-5488-1-git-send-email-rjbarnet@rockwellcollins.com |
|---|---|
| State | Accepted |
| Headers | show |
>>>>> "Ryan" == Ryan Barnett <ryanbarnett3@gmail.com> writes: > mpg123 needs MMU because the application that is built with this > package uses fork. Currently it is difficult to only build the > libraries for mpg123 so disabling the package all together when there > is no MMU support. > Note: mpg123 is an optional dependency of mpd but mpd already requires > BR2_USE_MMU so there is no need to add this as a dependency. > Fixes: > http://autobuild.buildroot.net/results/5b0/5b053af566dd122ae7e58893e77d5d5f3070fb9e > Signed-off-by: Ryan Barnett <rjbarnet@rockwellcollins.com> > --- > v1 -> v2 > - Added autobuild failure link > Signed-off-by: Ryan Barnett <rjbarnet@rockwellcollins.com> > --- > package/gstreamer1/gst1-plugins-bad/Config.in | 1 + > package/mpg123/Config.in | 1 + > 2 files changed, 2 insertions(+) > diff --git a/package/gstreamer1/gst1-plugins-bad/Config.in b/package/gstreamer1/gst1-plugins-bad/Config.in > index 407bf31..3647e53 100644 > --- a/package/gstreamer1/gst1-plugins-bad/Config.in > +++ b/package/gstreamer1/gst1-plugins-bad/Config.in > @@ -400,6 +400,7 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_MPEG2ENC > config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_MPG123 > bool "mpg123" > select BR2_PACKAGE_MPG123 > + depends on BR2_USE_MMU # mpg123 All of gstreamer1 depends on mmu (because of glib), so this is not really needed, but OK. Committed, thanks.
Peter, On Sat, Feb 22, 2014 at 9:35 PM, Peter Korsgaard <jacmet@uclibc.org> wrote: > All of gstreamer1 depends on mmu (because of glib), so this is not > really needed, but OK. That is what I meant to say. Sorry for the confusion! Thanks, -Ryan
diff --git a/package/gstreamer1/gst1-plugins-bad/Config.in b/package/gstreamer1/gst1-plugins-bad/Config.in index 407bf31..3647e53 100644 --- a/package/gstreamer1/gst1-plugins-bad/Config.in +++ b/package/gstreamer1/gst1-plugins-bad/Config.in @@ -400,6 +400,7 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_MPEG2ENC config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_MPG123 bool "mpg123" select BR2_PACKAGE_MPG123 + depends on BR2_USE_MMU # mpg123 help mp3 decoding based on the mpg123 library diff --git a/package/mpg123/Config.in b/package/mpg123/Config.in index 18ac41c..a7ac035 100644 --- a/package/mpg123/Config.in +++ b/package/mpg123/Config.in @@ -1,5 +1,6 @@ config BR2_PACKAGE_MPG123 bool "mpg123" + depends on BR2_USE_MMU # fork - in the application help Fast, free and portable MPEG audio player for Unix. It supports MPEG 1.0/2.0 layers 1, 2 and 3.