Message ID | 1391020967-19043-1-git-send-email-yann.morin.1998@free.fr |
---|---|
State | Superseded |
Headers | show |
Op 29-jan.-2014 19:43 schreef "Yann E. MORIN" <yann.morin.1998@free.fr>: > > From: "Yann E. MORIN" <yann.morin.1998@free.fr> > > The current default for BR2_PACKAGE_OVERRIDE_FILE points to: > $(TOPDIR)/local.mk > > This works well for in-tree builds, but is not very useful for > out-of-tree builds, when the Buildroot source tree may be shared for > different concurrent builds. > > Also, it seems to be more sensible to have local.mk alognside > the .config file. > > Hence, change the default for BR2_PACKAGE_OVERRIDE_FILE to point to: > $(CONFIG_DIR)/local.mk ... which in the default case equals TOPDIR, right? (Would be nice to clarify in the commit message)
Thomas, All, On 2014-01-29 21:45 +0100, Thomas De Schampheleire spake thusly: > Op 29-jan.-2014 19:43 schreef "Yann E. MORIN" <yann.morin.1998@free.fr>: > > > > From: "Yann E. MORIN" <yann.morin.1998@free.fr> > > > > The current default for BR2_PACKAGE_OVERRIDE_FILE points to: > > $(TOPDIR)/local.mk > > > > This works well for in-tree builds, but is not very useful for > > out-of-tree builds, when the Buildroot source tree may be shared for > > different concurrent builds. > > > > Also, it seems to be more sensible to have local.mk alognside > > the .config file. > > > > Hence, change the default for BR2_PACKAGE_OVERRIDE_FILE to point to: > > $(CONFIG_DIR)/local.mk > > ... which in the default case equals TOPDIR, right? (Would be nice to > clarify in the commit message) Oh, yes. I intended to write that part, but was absorbed by the very nice fumet of the dinner being cooked at the time I wrote the commit log. I plead guilty for having been disturbed by my nostrils, and my stomach! I'll respin with that added. Thank you! :-) Regards, Yann E. MORIN.
diff --git a/Config.in b/Config.in index 7ec7c2a..f8d6e23 100644 --- a/Config.in +++ b/Config.in @@ -488,7 +488,7 @@ config BR2_HAVE_DOCUMENTATION config BR2_PACKAGE_OVERRIDE_FILE string "location of a package override file" - default "$(TOPDIR)/local.mk" + default "$(CONFIG_DIR)/local.mk" help A package override file is a short makefile that contains variable definitions of the form <pkg>_OVERRIDE_SRCDIR,