From patchwork Tue Dec 10 19:07:19 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yann E. MORIN" X-Patchwork-Id: 299525 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137]) by ozlabs.org (Postfix) with ESMTP id BBFCB2C0458 for ; Wed, 11 Dec 2013 09:44:08 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id A32B6886BA; Tue, 10 Dec 2013 19:07:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Yiai4D0pOpuZ; Tue, 10 Dec 2013 19:07:39 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id DE07B8B0A1; Tue, 10 Dec 2013 19:07:38 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 936E51BF865 for ; Tue, 10 Dec 2013 19:07:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 8F0DA8AFA8 for ; Tue, 10 Dec 2013 19:07:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sQpGO4cVvY1o for ; Tue, 10 Dec 2013 19:07:35 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wg0-f48.google.com (mail-wg0-f48.google.com [74.125.82.48]) by whitealder.osuosl.org (Postfix) with ESMTPS id DD8AB843DB for ; Tue, 10 Dec 2013 19:07:34 +0000 (UTC) Received: by mail-wg0-f48.google.com with SMTP id z12so5334707wgg.15 for ; Tue, 10 Dec 2013 11:07:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=qnWDd435hc4iFh70D/XhCqYQLt8bPgwSX460NxdWN7A=; b=GWudxiagN2EWeHFidXgf87+QgLPJ6HB77woDKnWDbYweIIbhKp9Lh1M3jfFQbFtAmG fBmHPK8eu+l/rfRbWWO2qsrpI2OlH+H+exftkBue0Dh8jJYWke/PgE1oy0k/DAogQkX3 JMp7Ami0Ngcjq5Q4Cbu3IKlV3WWph9b5Ss1XvirU4Iq6zwPklB13j5g5aX5D51tS0aly 1MqOvGUUgt722bBQk7O9s2GwjCRJYN0DjLXjFXEfoISapwWJsnoOnheeiABXYazuPoTc 2HzhWDVfmugSdyRC3FBrJob+0+hRfTJBSjobtA5exhVKUNHS8P6pqqxiLo5UPNK9jx+I V+hQ== X-Received: by 10.194.189.42 with SMTP id gf10mr21739845wjc.24.1386702453465; Tue, 10 Dec 2013 11:07:33 -0800 (PST) Received: from gourin.bzh.lan (ks3095497.kimsufi.com. [94.23.60.27]) by mx.google.com with ESMTPSA id mz10sm7689405wic.2.2013.12.10.11.07.31 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 10 Dec 2013 11:07:32 -0800 (PST) From: "Yann E. MORIN" To: buildroot@busybox.net Date: Tue, 10 Dec 2013 20:07:19 +0100 Message-Id: <1386702439-10093-2-git-send-email-yann.morin.1998@free.fr> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1386702439-10093-1-git-send-email-yann.morin.1998@free.fr> References: <52A730B0.3020104@orange.com> <1386702439-10093-1-git-send-email-yann.morin.1998@free.fr> Cc: "Yann E. MORIN" Subject: [Buildroot] [PATCH] package/libgles: postpone the check for a missing GLES provider X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net From: "Yann E. MORIN" Because some GLES providers may be in BR2_EXTERNAL, $(LIBGLES_DEPENDENCIES) might be empty hwen we test it. So, we can't rely on it to define LIBGLES_CONFIGURE_CMDS, and we must postpone the check until later, ie. at runtime. Signed-off-by: "Yann E. MORIN" --- package/opengl/libgles/libgles.mk | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/package/opengl/libgles/libgles.mk b/package/opengl/libgles/libgles.mk index ec157ac..c2e1acf 100644 --- a/package/opengl/libgles/libgles.mk +++ b/package/opengl/libgles/libgles.mk @@ -22,11 +22,16 @@ ifeq ($(BR2_PACKAGE_GPU_VIV_BIN_MX6Q),y) LIBGLES_DEPENDENCIES += gpu-viv-bin-mx6q endif -ifeq ($(LIBGLES_DEPENDENCIES),) +# Because some GLES providers may be in BR2_EXTERNAL, +# $(LIBGLES_DEPENDENCIES) might be empty right here. +# So, we can't rely on it to define LIBGLES_CONFIGURE_CMDS +# right now, and we must postpone the check until later, +# ie. at runtime. define LIBGLES_CONFIGURE_CMDS - echo "No libGLES implementation selected. Configuration error." - exit 1 + if [ -z "$${LIBGLES_DEPENDENCIES}" ]; then \ + echo "No libGLES implementation selected. Configuration error."; \ + exit 1; \ + fi endef -endif $(eval $(generic-package))