| Message ID | 1384163348-17932-1-git-send-email-spdawson@gmail.com |
|---|---|
| State | Accepted |
| Commit | d71d7d162bb835f42403c930f19007fba90e2a91 |
| Headers | show |
>>>>> "spdawson" == spdawson <spdawson@gmail.com> writes: > From: Simon Dawson <spdawson@gmail.com> > uClibc 0.9.31.x does not include the pthread_setaffinity_np GNU extension. > Fixes build failures such as the following. > http://autobuild.buildroot.net/results/e21526c0c18733310d3fb322d79d5fff3a71af51/ > Signed-off-by: Simon Dawson <spdawson@gmail.com> > --- > package/iozone/Config.in | 1 + > 1 file changed, 1 insertion(+) > diff --git a/package/iozone/Config.in b/package/iozone/Config.in > index 26d4daa..33e12ca 100644 > --- a/package/iozone/Config.in > +++ b/package/iozone/Config.in > @@ -1,6 +1,7 @@ > config BR2_PACKAGE_IOZONE > bool "iozone" > depends on BR2_USE_MMU # fork() > + depends on !BR2_UCLIBC_VERSION_0_9_31 # no pthread_setaffinity_np Committed, thanks. It sounds like it also needs to depend on BR2_TOOLCHAIN_HAS_THREADS. Care to send a patch adding that dependency and a comment line?
Hi Peter, On 11 November 2013 09:53, Peter Korsgaard <jacmet@uclibc.org> wrote: > Committed, thanks. It sounds like it also needs to depend on > BR2_TOOLCHAIN_HAS_THREADS. Care to send a patch adding that dependency > and a comment line? Yes, okay. Simon.
Hi Peter, Simon, On Mon, Nov 11, 2013 at 10:53:57AM +0100, Peter Korsgaard wrote: > >>>>> "spdawson" == spdawson <spdawson@gmail.com> writes: > > > From: Simon Dawson <spdawson@gmail.com> > > uClibc 0.9.31.x does not include the pthread_setaffinity_np GNU extension. > > > Fixes build failures such as the following. > > > http://autobuild.buildroot.net/results/e21526c0c18733310d3fb322d79d5fff3a71af51/ > > > Signed-off-by: Simon Dawson <spdawson@gmail.com> > > --- > > package/iozone/Config.in | 1 + > > 1 file changed, 1 insertion(+) > > > diff --git a/package/iozone/Config.in b/package/iozone/Config.in > > index 26d4daa..33e12ca 100644 > > --- a/package/iozone/Config.in > > +++ b/package/iozone/Config.in > > @@ -1,6 +1,7 @@ > > config BR2_PACKAGE_IOZONE > > bool "iozone" > > depends on BR2_USE_MMU # fork() > > + depends on !BR2_UCLIBC_VERSION_0_9_31 # no pthread_setaffinity_np > > Committed, thanks. It sounds like it also needs to depend on > BR2_TOOLCHAIN_HAS_THREADS. Care to send a patch adding that dependency > and a comment line? It also depends on BR2_PTHREADS_NATIVE. linuxthreads doesn't have pthread_setaffinity_np. baruch
Hi Baruch, On 11 November 2013 10:01, Baruch Siach <baruch@tkos.co.il> wrote: > It also depends on BR2_PTHREADS_NATIVE. linuxthreads doesn't have > pthread_setaffinity_np. Okay, thanks. Simon.
Dear Baruch Siach, On Mon, 11 Nov 2013 12:01:50 +0200, Baruch Siach wrote: > > Committed, thanks. It sounds like it also needs to depend on > > BR2_TOOLCHAIN_HAS_THREADS. Care to send a patch adding that dependency > > and a comment line? > > It also depends on BR2_PTHREADS_NATIVE. linuxthreads doesn't have > pthread_setaffinity_np. It is not allowed to add a BR2_PTHREADS_NATIVE dependency to a package, because this symbol is meaningless in the context of the external toolchain backend. We probably need to add something like http://patchwork.ozlabs.org/patch/258723/, but updated, and with a check in the external toolchain code to verify that the selection matches the reality. Best regards, Thomas
diff --git a/package/iozone/Config.in b/package/iozone/Config.in index 26d4daa..33e12ca 100644 --- a/package/iozone/Config.in +++ b/package/iozone/Config.in @@ -1,6 +1,7 @@ config BR2_PACKAGE_IOZONE bool "iozone" depends on BR2_USE_MMU # fork() + depends on !BR2_UCLIBC_VERSION_0_9_31 # no pthread_setaffinity_np help IOzone is a filesystem benchmark tool. The benchmark generates and measures a variety of file operations