From patchwork Sat Nov 9 00:21:21 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnout Vandecappelle X-Patchwork-Id: 289947 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ozlabs.org (Postfix) with ESMTP id 507262C00C2 for ; Sat, 9 Nov 2013 11:21:35 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 883BA8B1B2; Sat, 9 Nov 2013 00:21:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W2Rz01P9PMNe; Sat, 9 Nov 2013 00:21:33 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 709998CB45; Sat, 9 Nov 2013 00:21:33 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 607791C2794 for ; Sat, 9 Nov 2013 00:21:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 4CA278CBCF for ; Sat, 9 Nov 2013 00:21:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XM9GmseX3fZt for ; Sat, 9 Nov 2013 00:21:29 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from viper.mind.be (132.79-246-81.adsl-static.isp.belgacom.be [81.246.79.132]) by whitealder.osuosl.org (Postfix) with ESMTPS id 2F7988A9A4 for ; Sat, 9 Nov 2013 00:21:29 +0000 (UTC) Received: from [172.16.2.6] (helo=vandecaa-laptop) by viper.mind.be with esmtp (Exim 4.69) (envelope-from ) id 1VewIC-0007oN-Kz; Sat, 09 Nov 2013 01:20:53 +0100 Received: from arnout by vandecaa-laptop with local (Exim 4.80) (envelope-from ) id 1VewIj-0004H0-IG; Sat, 09 Nov 2013 01:21:21 +0100 From: "Arnout Vandecappelle (Essensium/Mind)" To: buildroot@busybox.net Date: Sat, 9 Nov 2013 01:21:21 +0100 Message-Id: <1383956481-16389-2-git-send-email-arnout@mind.be> X-Mailer: git-send-email 1.8.4.2 In-Reply-To: <1383956481-16389-1-git-send-email-arnout@mind.be> References: <1383956481-16389-1-git-send-email-arnout@mind.be> Subject: [Buildroot] [PATCH v2 2/2] xorg: needs thread support X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net From: Jerzy Grzegorek libpthread-stubs, libX11, and a few more xorg packages use threads. Since almost all xorg packages depend on libX11 directory or indirectly, and since the remaining ones are pretty useless on their own, just require threads for xorg as a whole. The thread dependency is kept in libpthread-stubs, because that package will move out of the x11r7 directory later (pending patch by Spenser Gilliland), so the dependency on threads will be required then. Fixes: http://autobuild.buildroot.org/results/609/6099baac4bb469ae18aab6512233db25183eaabd/ [Arnout: disable all of xorg, correct comment] Signed-off-by: Jerzy Grzegorek Signed-off-by: Arnout Vandecappelle (Essensium/Mind) --- v2: - Patch taken over by Arnout - Resolve reverse dependencies of libpthread-stubs -- turns out all of xorg needs to be disabled - Change the comment according to the official pattern Signed-off-by: Arnout Vandecappelle (Essensium/Mind) --- package/x11r7/Config.in | 5 +++-- package/x11r7/xlib_libpthread-stubs/Config.in | 4 ++++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/package/x11r7/Config.in b/package/x11r7/Config.in index 09bc078..94cf7c6 100644 --- a/package/x11r7/Config.in +++ b/package/x11r7/Config.in @@ -1,6 +1,7 @@ menuconfig BR2_PACKAGE_XORG7 bool "X.org X Window System" depends on BR2_USE_WCHAR + depends on BR2_TOOLCHAIN_HAS_THREADS help Support for X11R7 libraries, servers, drivers, and/or applications in the target. @@ -261,5 +262,5 @@ if BR2_PACKAGE_XORG7 endmenu endif -comment "X.org needs a toolchain w/ wchar" - depends on !BR2_USE_WCHAR +comment "X.org needs a toolchain w/ wchar, threads" + depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS diff --git a/package/x11r7/xlib_libpthread-stubs/Config.in b/package/x11r7/xlib_libpthread-stubs/Config.in index fb53585..6ce1b94 100644 --- a/package/x11r7/xlib_libpthread-stubs/Config.in +++ b/package/x11r7/xlib_libpthread-stubs/Config.in @@ -1,7 +1,11 @@ config BR2_PACKAGE_XLIB_LIBPTHREAD_STUBS bool "libpthread-stubs" + depends on BR2_TOOLCHAIN_HAS_THREADS help This library provides weak aliases for pthread functions not provided in libc or otherwise available by default. http://xcb.freedesktop.org/ + +comment "libpthread-stubs needs a toolchain w/ threads" + depends on !BR2_TOOLCHAIN_HAS_THREADS