| Message ID | 1383471053-8243-1-git-send-email-spdawson@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
>>>>> "spdawson" == spdawson <spdawson@gmail.com> writes: > From: Simon Dawson <spdawson@gmail.com> > On avr32, dropwatch needs libiberty to avoid build failures such as > http://autobuild.buildroot.net/results/cd5/cd5e22fb5c9b0fc5d396bc85a5e253a1a65054da/ > Also test built on ARM. > Signed-off-by: Simon Dawson <spdawson@gmail.com> > --- > package/dropwatch/dropwatch-04-avr32-build.patch | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > create mode 100644 package/dropwatch/dropwatch-04-avr32-build.patch > diff --git a/package/dropwatch/dropwatch-04-avr32-build.patch b/package/dropwatch/dropwatch-04-avr32-build.patch > new file mode 100644 > index 0000000..e83e405 > --- /dev/null > +++ b/package/dropwatch/dropwatch-04-avr32-build.patch > @@ -0,0 +1,17 @@ > +On avr32, dropwatch needs libiberty to avoid build failures such as > + > + http://autobuild.buildroot.net/results/cd5/cd5e22fb5c9b0fc5d396bc85a5e253a1a65054da/ > + > +Signed-off-by: Simon Dawson <spdawson@gmail.com> > + > +diff -Nurp a/src/Makefile b/src/Makefile > +--- a/src/Makefile 2013-11-03 09:22:16.713210025 +0000 > ++++ b/src/Makefile 2013-11-03 09:22:59.465126490 +0000 > +@@ -1,6 +1,6 @@ > + all: dropwatch > + CFLAGS+=-c -g -D_GNU_SOURCE -Wall `pkg-config --cflags libnl-3.0` > +-LDFLAGS=-lbfd -lreadline -lnl-3 -lnl-genl-3 > ++LDFLAGS=-lbfd -liberty -lreadline -lnl-3 -lnl-genl-3 I think you need to adjust the BR2_NEEDS_GETTEXT_IF_LOCALE condition in dropwatch.mk as well, and it would probably be better to handle it in dropwatch.mk for both cases instead of this patch + override.
Thanks for the feedback Peter. On 4 November 2013 23:14, Peter Korsgaard <jacmet@uclibc.org> wrote: > I think you need to adjust the BR2_NEEDS_GETTEXT_IF_LOCALE condition in > dropwatch.mk as well, and it would probably be better to handle it in > dropwatch.mk for both cases instead of this patch + override. Okay. Will rework the patch. Simon.
diff --git a/package/dropwatch/dropwatch-04-avr32-build.patch b/package/dropwatch/dropwatch-04-avr32-build.patch new file mode 100644 index 0000000..e83e405 --- /dev/null +++ b/package/dropwatch/dropwatch-04-avr32-build.patch @@ -0,0 +1,17 @@ +On avr32, dropwatch needs libiberty to avoid build failures such as + + http://autobuild.buildroot.net/results/cd5/cd5e22fb5c9b0fc5d396bc85a5e253a1a65054da/ + +Signed-off-by: Simon Dawson <spdawson@gmail.com> + +diff -Nurp a/src/Makefile b/src/Makefile +--- a/src/Makefile 2013-11-03 09:22:16.713210025 +0000 ++++ b/src/Makefile 2013-11-03 09:22:59.465126490 +0000 +@@ -1,6 +1,6 @@ + all: dropwatch + CFLAGS+=-c -g -D_GNU_SOURCE -Wall `pkg-config --cflags libnl-3.0` +-LDFLAGS=-lbfd -lreadline -lnl-3 -lnl-genl-3 ++LDFLAGS=-lbfd -liberty -lreadline -lnl-3 -lnl-genl-3 + OBJFILES := main.o lookup.o\ + lookup_bfd.o lookup_kas.o +