diff mbox

[2/3] weston: add missing toolchain comments

Message ID 1381525213-14034-2-git-send-email-arnout@mind.be
State Changes Requested
Delegated to: Yann E. MORIN
Headers show

Commit Message

Arnout Vandecappelle Oct. 11, 2013, 9 p.m. UTC
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 package/weston/Config.in | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Comments

Yann E. MORIN Oct. 11, 2013, 9:10 p.m. UTC | #1
Arnout, All,

On 2013-10-11 23:00 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly:
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
>  package/weston/Config.in | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/package/weston/Config.in b/package/weston/Config.in
> index fd48fb3..ea0e87e 100644
> --- a/package/weston/Config.in
> +++ b/package/weston/Config.in
> @@ -1,5 +1,5 @@
> -comment "weston requires udev"
> -	depends on !BR2_PACKAGE_UDEV
> +comment "weston needs udev and a toolchain w/ threads"
> +	depends on !BR2_PACKAGE_UDEV || !BR2_TOOLCHAIN_HAS_THREADS

Doh, I just forgot about this... Thanks! :-)

>  config BR2_PACKAGE_WESTON
>  	bool "weston"
> @@ -30,6 +30,10 @@ if BR2_PACKAGE_WESTON
>  config BR2_PACKAGE_WESTON_HAS_COMPOSITOR
>  	bool
>  
> +comment "RPi compositor needs a toolchain w/ C++, largefile, threads

Missing terminating double-quotes.

> +	depends on BR2_arm
> +	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS
> +
>  config BR2_PACKAGE_WESTON_RPI
>  	bool "RPi compositor"
>  	depends on BR2_arm                      # rpi-userland

Otherwise:
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.
diff mbox

Patch

diff --git a/package/weston/Config.in b/package/weston/Config.in
index fd48fb3..ea0e87e 100644
--- a/package/weston/Config.in
+++ b/package/weston/Config.in
@@ -1,5 +1,5 @@ 
-comment "weston requires udev"
-	depends on !BR2_PACKAGE_UDEV
+comment "weston needs udev and a toolchain w/ threads"
+	depends on !BR2_PACKAGE_UDEV || !BR2_TOOLCHAIN_HAS_THREADS
 
 config BR2_PACKAGE_WESTON
 	bool "weston"
@@ -30,6 +30,10 @@  if BR2_PACKAGE_WESTON
 config BR2_PACKAGE_WESTON_HAS_COMPOSITOR
 	bool
 
+comment "RPi compositor needs a toolchain w/ C++, largefile, threads
+	depends on BR2_arm
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS
+
 config BR2_PACKAGE_WESTON_RPI
 	bool "RPi compositor"
 	depends on BR2_arm                      # rpi-userland