From patchwork Mon Sep 23 09:16:50 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Lin X-Patchwork-Id: 277119 X-Patchwork-Delegate: thomas.petazzoni@free-electrons.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ozlabs.org (Postfix) with ESMTP id BE62F2C0169 for ; Mon, 23 Sep 2013 19:16:59 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 10D578B2AF; Mon, 23 Sep 2013 09:16:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wQkT9GycuhMg; Mon, 23 Sep 2013 09:16:57 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 34B8E8AD5F; Mon, 23 Sep 2013 09:16:57 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id B7BD91C28D5 for ; Mon, 23 Sep 2013 09:16:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id B36D68AD5F for ; Mon, 23 Sep 2013 09:16:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eTkRwJHCGSLD for ; Mon, 23 Sep 2013 09:16:54 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pb0-f41.google.com (mail-pb0-f41.google.com [209.85.160.41]) by whitealder.osuosl.org (Postfix) with ESMTPS id DE45C8A9CD for ; Mon, 23 Sep 2013 09:16:54 +0000 (UTC) Received: by mail-pb0-f41.google.com with SMTP id rp2so2988127pbb.28 for ; Mon, 23 Sep 2013 02:16:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:content-type :mime-version:content-transfer-encoding; bh=+toeOYIXPUrMnF4nb/RVZxuFz79b+qzfxja19eB5SaY=; b=JwXsjPhPqSW6p4GLVaJEC7rFUTz+UGGIEgipJoBtg67QvrRjnIRohcYjycbIvuKCvy 8wtutGC5sjU70ehYJJEpH26Fr5YV2K2p4BwyA8WrT1fWhmbiGVlRjrDLaQi8TiR+5QrS OJ6H/NqhuN/nRIKWRWvsfkS+VNL+0W4nfUlhagzOvuG2H55LAyGhQQHZmbfdBLKJa1kJ p1yZPDxOw4bBPhcgy+U8BS7HtgbuGF6UDWZ+T3+hTg8T2UKVw1X7jNLkE1kHolo6IfqW XoUSknhRoGfCvT0GRrawKTQUFMo8s+z/X9MV7yXd5tUHpGGh661iaEyUBHzIRUrjBVQ1 yn7A== X-Gm-Message-State: ALoCoQmcVltfhtjOexKDMLr3NUkGvuNqJbboRqyrIfLPva/rc7GFETQr6eAQg85YZmKs4/I3qq1Y X-Received: by 10.66.145.166 with SMTP id sv6mr23380760pab.31.1379927814481; Mon, 23 Sep 2013 02:16:54 -0700 (PDT) Received: from [192.168.0.102] (218-164-97-212.dynamic.hinet.net. [218.164.97.212]) by mx.google.com with ESMTPSA id fl3sm36702726pad.10.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 23 Sep 2013 02:16:54 -0700 (PDT) Message-ID: <1379927810.16071.2.camel@phoenix> From: Axel Lin To: Peter Korsgaard Date: Mon, 23 Sep 2013 17:16:50 +0800 X-Mailer: Evolution 3.6.4-0ubuntu1 Mime-Version: 1.0 Cc: Thomas Petazzoni , buildroot@busybox.net Subject: [Buildroot] [PATCH RESEND] package/Makefile.in: Fix dependency for selecting uclinux as TARGET_OS X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net Current setting only allows blackfin to select uclinux as TARGET_OS. However, some noMMU ARM platforms that using FLAT binary format also need to select uclinux as TARGET_OS. Fix the dependency. Signed-off-by: Axel Lin Acked-by: Thomas Petazzoni --- This patch was sent on http://lists.busybox.net/pipermail/buildroot/2013-September/077488.html I found that without this patch, I hit below build error: __uClibc_main.c:(.text+0x240): undefined reference to `__preinit_array_start' __uClibc_main.c:(.text+0x244): undefined reference to `__preinit_array_end' __uClibc_main.c:(.text+0x248): undefined reference to `__init_array_start' __uClibc_main.c:(.text+0x24c): undefined reference to `__init_array_end' /opt/test/buildroot/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/bin/ld.real: ./libgcc_s.so.1.tmp: hidden symbol `__fini_array_end' isn't defined /opt/test/buildroot/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/bin/ld.real: final link failed: Bad value collect2: ld returned 1 exit status make[3]: *** [libgcc_s.so] Error 1 make[3]: Leaving directory `/opt/test/buildroot/buildroot/output/build/host-gcc-final-4.5.4/build/arm-buildroot-linux-uclibcgnueabi/libgcc' make[2]: *** [all-target-libgcc] Error 2 make[2]: Leaving directory `/opt/test/buildroot/buildroot/output/build/host-gcc-final-4.5.4/build' make[1]: *** [all] Error 2 make[1]: Leaving directory `/opt/test/buildroot/buildroot/output/build/host-gcc-final-4.5.4/build' make: *** [/opt/test/buildroot/buildroot/output/build/host-gcc-final-4.5.4/.stamp_built] Error 2 I remember that someone has reported the same build error on the maillist. With this patch, the build result looks OK. package/Makefile.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package/Makefile.in b/package/Makefile.in index 170ad78..1699fdf 100644 --- a/package/Makefile.in +++ b/package/Makefile.in @@ -23,8 +23,8 @@ MAKE:=$(HOSTMAKE) -j$(PARALLEL_JOBS) # Compute GNU_TARGET_NAME GNU_TARGET_NAME=$(ARCH)-buildroot-$(TARGET_OS)-$(LIBC)$(ABI) -# Blackfin FLAT needs uclinux -ifeq ($(BR2_bfin)$(BR2_BINFMT_FLAT),yy) +# FLAT binary format needs uclinux +ifeq ($(BR2_BINFMT_FLAT),y) TARGET_OS=uclinux else TARGET_OS=linux