From patchwork Fri Sep 6 05:45:49 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Lin X-Patchwork-Id: 273066 X-Patchwork-Delegate: thomas.petazzoni@free-electrons.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from hemlock.osuosl.org (hemlock.osuosl.org [140.211.166.133]) by ozlabs.org (Postfix) with ESMTP id 060322C00E4 for ; Fri, 6 Sep 2013 15:45:59 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 5AB9A89479; Fri, 6 Sep 2013 05:46:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jqitlg0sL5r2; Fri, 6 Sep 2013 05:46:52 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 3A199930AD; Fri, 6 Sep 2013 05:46:52 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 3FE021C2EB3 for ; Fri, 6 Sep 2013 05:45:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 339668CAB8 for ; Fri, 6 Sep 2013 05:45:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MubUpVTKTHlI for ; Fri, 6 Sep 2013 05:45:55 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pa0-f45.google.com (mail-pa0-f45.google.com [209.85.220.45]) by whitealder.osuosl.org (Postfix) with ESMTPS id 236E38CA82 for ; Fri, 6 Sep 2013 05:45:55 +0000 (UTC) Received: by mail-pa0-f45.google.com with SMTP id bg4so2883308pad.4 for ; Thu, 05 Sep 2013 22:45:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:content-type :mime-version:content-transfer-encoding; bh=EGdh3hIgVuH9diHsQIfv74LOt3G/wDPXyJXoD+wkDzY=; b=Rux9sijt7e48/dwtvMha4yqjWKgMmPXGA6Tpi45cHfgW8unIDT7xfDNphE8g/X7xBq QZzve57/qJMdiwCA7ZF9AOXaUahsCNqWeetq9IrTRUAkwxepjJ2iH2G6Dlod69heXMr6 MbhXSiceenWnMdsFGrDorzmLa4fY4tybQxVhtRViaHwwpSI/z3xtZbc1As33idRfDuRz keYcOh9Jjii4sIx1QnmqIn7stQ1wq8Q4W2PgsZngXmkkPBSPCZm2Jik8jrfG6czs0ZUD pOuK75wzYEhjzh54yWPim+aK9fFupoUeDZQzxgSzQtooSGMT+kAvPz/TxVd3FOAAXqp/ ekQw== X-Gm-Message-State: ALoCoQn7S1zflkx5xIUM52c765DoKvrOazihGHpNb8Hw3rIHtYRCq34maV8zP3VG78jrcv4QEw0X X-Received: by 10.66.155.102 with SMTP id vv6mr1865041pab.89.1378446354808; Thu, 05 Sep 2013 22:45:54 -0700 (PDT) Received: from [192.168.0.102] (218-164-128-112.dynamic.hinet.net. [218.164.128.112]) by mx.google.com with ESMTPSA id xl3sm1350030pbb.17.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 05 Sep 2013 22:45:54 -0700 (PDT) Message-ID: <1378446349.27719.2.camel@phoenix> From: Axel Lin To: buildroot@busybox.net Date: Fri, 06 Sep 2013 13:45:49 +0800 X-Mailer: Evolution 3.6.4-0ubuntu1 Mime-Version: 1.0 Cc: Thomas Petazzoni , Thomas De Schampheleire Subject: [Buildroot] [PATCH] arch/Config.in: Allow arm7tdmi to select BR2_BINFMT_FLAT X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net Allow BR2_arm7tdmi to select BR2_BINFMT_FLAT by adding BR2_arm7tdmi to BR2_BINFMT_FLAT dependency. Remove BR2_m68k dependency for BR2_BINFMT_FDPIC because m68k does not support FDPIC. Also update BR2_BINFMT_ELF dependency to exclude BR2_arm7tdmi. So users of MMU-capable ARM variants wouldn't be confused by the availability of FLAT and ELF as binary formats. Signed-off-by: Axel Lin Cc: Thomas Petazzoni Cc: Thomas De Schampheleire --- This is v2 of "[PATCH 2/2] arch/Config.in: Allow ARM to select BR2_BINFMT_FLAT", I change the subject line because it actually allows arm7tdmi to select BR2_BINFMT_FLAT. The changes in v2: Add BR2_arm7tdmi rather than BR2_arm to BR2_BINFMT_FLAT dependency. Remove BR2_m68k dependency for BR2_BINFMT_FDPIC. Also update BR2_BINFMT_ELF dependency to exclude BR2_arm7tdmi. Note: I didn't add BR2_arm_cortex_m3 and BR2_arm_cortex_m4 to the dependency in this patch because they are not exist in current build system. And I think it's ok to have an incremental patch for adding them when they are supported by buildroot. I think further improvement for using !BR2_USE_MMU dependency suggested by Thomas Petazzoni or having "ARCH_HAS_MMU and/or ARCH_SUPPORTS_FLAT_BINARY" suggested by Thomas De Schampheleire can also be in incremental patchs. Regards, Axel Signed-off-by: Axel Lin --- arch/Config.in | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/arch/Config.in b/arch/Config.in index 3fd8c1c..f88594c 100644 --- a/arch/Config.in +++ b/arch/Config.in @@ -225,12 +225,13 @@ config BR2_GCC_TARGET_MODE # Set up target binary format choice prompt "Target Binary Format" - depends on BR2_bfin || BR2_m68k - default BR2_BINFMT_FDPIC + depends on BR2_arm7tdmi || BR2_m68k || BR2_bfin + default BR2_BINFMT_FLAT if BR2_arm7tdmi || BR2_m68k + default BR2_BINFMT_FDPIC if BR2_bfin config BR2_BINFMT_ELF bool "ELF" - depends on !BR2_bfin && !BR2_m68k + depends on !BR2_arm7tdmi && !BR2_bfin && !BR2_m68k help ELF (Executable and Linkable Format) is a format for libraries and executables used across different architectures and operating @@ -238,7 +239,7 @@ config BR2_BINFMT_ELF config BR2_BINFMT_FDPIC bool "FDPIC" - depends on BR2_bfin || BR2_m68k + depends on BR2_bfin help ELF FDPIC binaries are based on ELF, but allow the individual load segments of a binary to be located in memory independently of each @@ -247,7 +248,7 @@ config BR2_BINFMT_FDPIC config BR2_BINFMT_FLAT bool "FLAT" - depends on BR2_bfin || BR2_m68k + depends on BR2_arm7tdmi || BR2_bfin || BR2_m68k select BR2_PREFER_STATIC_LIB help FLAT binary is a relatively simple and lightweight executable format