From patchwork Tue May 28 18:21:29 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Petazzoni X-Patchwork-Id: 246931 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ozlabs.org (Postfix) with ESMTP id 60AF62C032D for ; Wed, 29 May 2013 04:21:51 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id F385D8D22D; Tue, 28 May 2013 18:21:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hVsghyrBbq6b; Tue, 28 May 2013 18:21:43 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 9BC758D211; Tue, 28 May 2013 18:21:42 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (hemlock.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 5BD9A8F75E for ; Tue, 28 May 2013 18:21:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 6B9D6A023D for ; Tue, 28 May 2013 18:21:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rb3EbhJeVhdE for ; Tue, 28 May 2013 18:21:30 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.free-electrons.com (mail.free-electrons.com [94.23.35.102]) by hemlock.osuosl.org (Postfix) with ESMTP id 5A12CA023A for ; Tue, 28 May 2013 18:21:30 +0000 (UTC) Received: by mail.free-electrons.com (Postfix, from userid 106) id D6BFFE45; Tue, 28 May 2013 20:21:29 +0200 (CEST) Received: from localhost (AToulouse-651-1-103-162.w109-222.abo.wanadoo.fr [109.222.70.162]) by mail.free-electrons.com (Postfix) with ESMTPSA id 4AD14D for ; Tue, 28 May 2013 20:21:29 +0200 (CEST) From: Thomas Petazzoni To: buildroot@uclibc.org Date: Tue, 28 May 2013 20:21:29 +0200 Message-Id: <1369765289-30040-1-git-send-email-thomas.petazzoni@free-electrons.com> X-Mailer: git-send-email 1.7.9.5 Subject: [Buildroot] [PATCH v2] lttng-babeltrace: fix build failure on gcc14 X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net The gcc14 machine has a moderately old host gcc, which was causing a recurrent build failure of host-lttng-babeltrace: http://autobuild.buildroot.org/results/492/49216052c161874f41738e41e6e0c89a6dd04000/build-end.log This commit adds a patch to fix this build failure, related to the access of the ULLONG_MAX define on compilers that did not default to the C99 variant of the C language. Signed-off-by: Thomas Petazzoni --- v2: Also autoreconf the target package, for consistency. --- ...beltrace-01-no-posix-fallocate-in-uclibc.patch} | 0 ...tng-babeltrace-02-fix-build-old-compilers.patch | 27 ++++++++++++++++++++ package/lttng-babeltrace/lttng-babeltrace.mk | 4 +++ 3 files changed, 31 insertions(+) rename package/lttng-babeltrace/{lttng-babeltrace-no-posix-fallocate-in-uclibc.patch => lttng-babeltrace-01-no-posix-fallocate-in-uclibc.patch} (100%) create mode 100644 package/lttng-babeltrace/lttng-babeltrace-02-fix-build-old-compilers.patch diff --git a/package/lttng-babeltrace/lttng-babeltrace-no-posix-fallocate-in-uclibc.patch b/package/lttng-babeltrace/lttng-babeltrace-01-no-posix-fallocate-in-uclibc.patch similarity index 100% rename from package/lttng-babeltrace/lttng-babeltrace-no-posix-fallocate-in-uclibc.patch rename to package/lttng-babeltrace/lttng-babeltrace-01-no-posix-fallocate-in-uclibc.patch diff --git a/package/lttng-babeltrace/lttng-babeltrace-02-fix-build-old-compilers.patch b/package/lttng-babeltrace/lttng-babeltrace-02-fix-build-old-compilers.patch new file mode 100644 index 0000000..b8f31be --- /dev/null +++ b/package/lttng-babeltrace/lttng-babeltrace-02-fix-build-old-compilers.patch @@ -0,0 +1,27 @@ +Support old compilers + +Some old compilers do not use C99 as their default C language variant, +for example gcc 4.3.x, which is used on some old machines. When such a +compiler is used, by default, ULLONG_MAX is not visible. Adding +-std=gnu99 is needed to make this definition visible. + +In autoconf speak, this translates into the need of using +AC_PROC_CC_STDC instead of AC_PROG_CC. See +http://www.gnu.org/software/autoconf/manual/autoconf-2.65/html_node/C-Compiler.html +for more details. + +Signed-off-by: Thomas Petazzoni + +Index: b/configure.ac +=================================================================== +--- a/configure.ac ++++ b/configure.ac +@@ -17,7 +17,7 @@ + AC_SYS_LARGEFILE + + # Checks for programs. +-AC_PROG_CC ++AC_PROG_CC_STDC + AC_PROG_MAKE_SET + LT_INIT + AC_PROG_YACC diff --git a/package/lttng-babeltrace/lttng-babeltrace.mk b/package/lttng-babeltrace/lttng-babeltrace.mk index 82376a3..d3bfc83 100644 --- a/package/lttng-babeltrace/lttng-babeltrace.mk +++ b/package/lttng-babeltrace/lttng-babeltrace.mk @@ -4,5 +4,9 @@ LTTNG_BABELTRACE_SOURCE = babeltrace-$(LTTNG_BABELTRACE_VERSION).tar.bz2 LTTNG_BABELTRACE_DEPENDENCIES = popt util-linux libglib2 +# One patch touches configure.ac +LTTNG_BABELTRACE_AUTORECONF = YES +HOST_LTTNG_BABELTRACE_AUTORECONF = YES + $(eval $(autotools-package)) $(eval $(host-autotools-package))