[1/2] glibmm: new package

Signed-off-by: Nicolas Ménégale  <nicolas.menegale@openwide.fr>
---
v1: added BR2_INSTALL_LIBSTDCPP and BR2_USE_WCHAR
glibmm is also a dependency of libxml++ (the libxml2 c++ wrapper)
Signed-off-by: nmenegale <nicolas.menegale@openwide.fr>
---
 package/Config.in        |  1 +
 package/glibmm/Config.in | 13 +++++++++++++
 package/glibmm/glibmm.mk | 13 +++++++++++++
 3 files changed, 27 insertions(+)
 create mode 100644 package/glibmm/Config.in
 create mode 100644 package/glibmm/glibmm.mk

Dear nmenegale,

On Wed, 24 Apr 2013 10:13:55 +0200, nmenegale wrote:

> diff --git a/package/glibmm/glibmm.mk b/package/glibmm/glibmm.mk
> new file mode 100644
> index 0000000..f7f49bd
> --- /dev/null
> +++ b/package/glibmm/glibmm.mk
> @@ -0,0 +1,13 @@
> +#############################################################
> +#
> +# Glibmm
> +#
> +#############################################################
> +GLIBMM_VERSION = 2.30.1
> +GLIBMM_LICENSE = LGPLv2.1
> +GLIBMM_SOURCE = glibmm-$(GLIBMM_VERSION).tar.bz2
> +GLIBMM_SITE = http://ftp.gnome.org/pub/gnome/sources/glibmm/2.30
> +GLIBMM_INSTALL_STAGING = YES
> +GLIBMM_DEPENDENCIES = libglib2 libsigc host-pkgconf
> +
> +$(eval $(autotools-package))

A few minor comments:

 * Please add an empty new line between  the header and the the first
   variable.

 * Maybe you should split the version number in two variables in order
   to re-use it for the site:

GLIBMM_VERSION_MAJOR = 2.30
GLIBMM_VERSION_MINOR = 1
GLIBMM_VERSION = $(GLIBMM_VERSION_MAJOR).$(GLIBMM_VERSION_MINOR)
GLIBMM_SITE = http://ftp.gnome.org/pub/gnome/sources/glibmm/$(GLIBMM_VERSION_MAJOR)

 * The licensing informations is not entirely correct. I think it
   should be:

GLIBMM_LICENSE = LGPLv2.1+ (library), GPLv2+ (tools)
GLIBMM_LICENSE_FILES = COPYING COPYING.tools

Best regards,

Thomas

Dear nmenegale,

On Wed, 24 Apr 2013 10:13:55 +0200, nmenegale wrote:

> +GLIBMM_SOURCE = glibmm-$(GLIBMM_VERSION).tar.bz2

I believe you could use the .tar.xz tarball instead, it's a bit smaller
to download.

Thanks,

Thomas

>>>>> "nmenegale" == nmenegale  <nicolas.menegale@openwide.fr> writes:

 nmenegale> Signed-off-by: Nicolas Ménégale  <nicolas.menegale@openwide.fr>
 nmenegale> ---
 nmenegale> v1: added BR2_INSTALL_LIBSTDCPP and BR2_USE_WCHAR
 nmenegale> glibmm is also a dependency of libxml++ (the libxml2 c++ wrapper)
 nmenegale> Signed-off-by: nmenegale <nicolas.menegale@openwide.fr>
 nmenegale> ---
 nmenegale>  package/Config.in        |  1 +
 nmenegale>  package/glibmm/Config.in | 13 +++++++++++++
 nmenegale>  package/glibmm/glibmm.mk | 13 +++++++++++++
 nmenegale>  3 files changed, 27 insertions(+)
 nmenegale>  create mode 100644 package/glibmm/Config.in
 nmenegale>  create mode 100644 package/glibmm/glibmm.mk

 nmenegale> diff --git a/package/Config.in b/package/Config.in
 nmenegale> index 06bcdef..c75c3ec 100644
 nmenegale> --- a/package/Config.in
 nmenegale> +++ b/package/Config.in
 nmenegale> @@ -558,6 +558,7 @@ source "package/fftw/Config.in"
 nmenegale>  source "package/libargtable2/Config.in"
 nmenegale>  source "package/argp-standalone/Config.in"
 nmenegale>  source "package/boost/Config.in"
 nmenegale> +source "package/glibmm/Config.in"
 nmenegale>  source "package/gmp/Config.in"
 nmenegale>  source "package/gsl/Config.in"
 nmenegale>  source "package/gtest/Config.in"
 nmenegale> diff --git a/package/glibmm/Config.in b/package/glibmm/Config.in
 nmenegale> new file mode 100644
 nmenegale> index 0000000..012b681
 nmenegale> --- /dev/null
 nmenegale> +++ b/package/glibmm/Config.in
 nmenegale> @@ -0,0 +1,13 @@
 nmenegale> +config BR2_PACKAGE_GLIBMM
 nmenegale> +	bool "glibmm"
 nmenegale> +	select BR2_PACKAGE_LIBGLIB2
 nmenegale> +	select BR2_PACKAGE_LIBSIGC
 nmenegale> +	depends on BR2_INSTALL_LIBSTDCPP
 nmenegale> +	depends on BR2_USE_WCHAR
 nmenegale> +	help
 nmenegale> +	  The GLibmm package is a set of C++ bindings for GLib. 
 nmenegale> +	  	

There's some stray trailing spaces here. Committed with that fixed,
thanks.