From patchwork Sun Jan 20 23:52:14 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Petazzoni X-Patchwork-Id: 214008 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from hemlock.osuosl.org (hemlock.osuosl.org [140.211.166.133]) by ozlabs.org (Postfix) with ESMTP id B80822C008D for ; Mon, 21 Jan 2013 10:54:15 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id EE83FA018C; Sun, 20 Jan 2013 23:54:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ipI+8F3GP331; Sun, 20 Jan 2013 23:54:10 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id B84BCA0148; Sun, 20 Jan 2013 23:54:06 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 664398F74B for ; Sun, 20 Jan 2013 23:54:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 5BBFF10026F for ; Sun, 20 Jan 2013 23:53:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m7xhB2fdD-0h for ; Sun, 20 Jan 2013 23:53:48 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.free-electrons.com (mail.free-electrons.com [94.23.35.102]) by fraxinus.osuosl.org (Postfix) with ESMTP id F2B37101570 for ; Sun, 20 Jan 2013 23:53:06 +0000 (UTC) Received: by mail.free-electrons.com (Postfix, from userid 106) id 055105EDC; Mon, 21 Jan 2013 00:53:16 +0100 (CET) Received: from localhost (unknown [37.160.30.44]) by mail.free-electrons.com (Postfix) with ESMTPSA id 0758C5ECE for ; Mon, 21 Jan 2013 00:52:57 +0100 (CET) From: Thomas Petazzoni To: buildroot@uclibc.org Date: Mon, 21 Jan 2013 00:52:14 +0100 Message-Id: <1358725943-31485-6-git-send-email-thomas.petazzoni@free-electrons.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1358725943-31485-1-git-send-email-thomas.petazzoni@free-electrons.com> References: <1358725943-31485-1-git-send-email-thomas.petazzoni@free-electrons.com> Subject: [Buildroot] [RFC v1 05/14] autotools infrastructure: do the autoreconf as a post patch step X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net Doing the autoreconf step as a pre-configure hook doesn't work properly, because the source directory is read-only during the configure step. And in fact, the autoreconf process modifies the source code, so it is quite logical to do it as part of the patching process rather than the configuration process. Signed-off-by: Thomas Petazzoni --- package/pkg-autotools.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/pkg-autotools.mk b/package/pkg-autotools.mk index bd87253..ec394fd 100644 --- a/package/pkg-autotools.mk +++ b/package/pkg-autotools.mk @@ -214,7 +214,7 @@ $(2)_DEPENDENCIES ?= $(filter-out host-automake host-autoconf host-libtool $(1), ifeq ($$($(2)_AUTORECONF),YES) -$(2)_PRE_CONFIGURE_HOOKS += AUTORECONF_HOOK +$(2)_POST_PATCH_HOOKS += AUTORECONF_HOOK $(2)_DEPENDENCIES += host-automake host-autoconf host-libtool endif