diff mbox

[2/2] Adding media-ctl as a package

Message ID 1357734594-8211-2-git-send-email-kpa_info@yahoo.fr
State Superseded
Headers show

Commit Message

kpa_info@yahoo.fr Jan. 9, 2013, 12:29 p.m. UTC 
From: Patrick Gerber <kpa_info@yahoo.fr>


Signed-off-by: Patrick Gerber <kpa_info@yahoo.fr>
---
 package/Config.in              |    1 +
 package/media-ctl/Config.in    |    4 ++++
 package/media-ctl/media-ctl.mk |   18 ++++++++++++++++++
 3 files changed, 23 insertions(+)
 create mode 100644 package/media-ctl/Config.in
 create mode 100644 package/media-ctl/media-ctl.mk

Comments

Thomas Petazzoni Jan. 9, 2013, 4:02 p.m. UTC | #1 
Dear kpa_info@yahoo.fr,

On Wed,  9 Jan 2013 13:29:54 +0100, kpa_info@yahoo.fr wrote:
> +config BR2_PACKAGE_MEDIA_CTL
> +	bool "media-ctl"
> +	help
> +	  Media controller control application

One empty newline + upstream URL of the project (even if it's just a
http link to the Git repository). And also the description seems a bit
short, since it does not only contains an application, but also a
library, no?

> diff --git a/package/media-ctl/media-ctl.mk
> b/package/media-ctl/media-ctl.mk new file mode 100644
> index 0000000..3c35278
> --- /dev/null
> +++ b/package/media-ctl/media-ctl.mk
> @@ -0,0 +1,18 @@
> +#############################################################
> +#
> +# media-ctl
> +#
> +#############################################################
> +
> +MEDIA_CTL_VERSION = ac40b79f002a2315f909548614ccd2d408da25b7
> +MEDIA_CTL_SITE = git://git.ideasonboard.org/media-ctl.git
> +MEDIA_CTL_INSTALL_STAGING = YES
> +MEDIA_CTL_LICENSE = GPLv2

The license is LGPLv2.1+.

> +MEDIA_CTL_LICENSE_FILES = COPYING.LIB
> +
> +MEDIA_CTL_AUTORECONF = YES
> +MEDIA_CTL_AUTORECONF_OPT = --install

Are you sure this AUTORECONF_OPT is needed? If so, then please add a
comment before this line that explains why.

> +MEDIA_CTL_CONF_OPT = --with-kernel-headers=$(STAGING_DIR)/usr/include
> +MEDIA_CTL_DEPENDENCIES = host-pkgconf
> +
> +$(eval $(autotools-package))

Otherwise, looks good, thanks!

Thomas
diff mbox

Patch

diff --git a/package/Config.in b/package/Config.in
index bd1db6b..2f3b601 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -245,6 +245,7 @@  source "package/lshw/Config.in"
 source "package/lsuio/Config.in"
 source "package/lvm2/Config.in"
 source "package/mdadm/Config.in"
+source "package/media-ctl/Config.in"
 source "package/memtester/Config.in"
 source "package/minicom/Config.in"
 source "package/nanocom/Config.in"
diff --git a/package/media-ctl/Config.in b/package/media-ctl/Config.in
new file mode 100644
index 0000000..9fb888c
--- /dev/null
+++ b/package/media-ctl/Config.in
@@ -0,0 +1,4 @@ 
+config BR2_PACKAGE_MEDIA_CTL
+	bool "media-ctl"
+	help
+	  Media controller control application
diff --git a/package/media-ctl/media-ctl.mk b/package/media-ctl/media-ctl.mk
new file mode 100644
index 0000000..3c35278
--- /dev/null
+++ b/package/media-ctl/media-ctl.mk
@@ -0,0 +1,18 @@ 
+#############################################################
+#
+# media-ctl
+#
+#############################################################
+
+MEDIA_CTL_VERSION = ac40b79f002a2315f909548614ccd2d408da25b7
+MEDIA_CTL_SITE = git://git.ideasonboard.org/media-ctl.git
+MEDIA_CTL_INSTALL_STAGING = YES
+MEDIA_CTL_LICENSE = GPLv2
+MEDIA_CTL_LICENSE_FILES = COPYING.LIB
+
+MEDIA_CTL_AUTORECONF = YES
+MEDIA_CTL_AUTORECONF_OPT = --install
+MEDIA_CTL_CONF_OPT = --with-kernel-headers=$(STAGING_DIR)/usr/include
+MEDIA_CTL_DEPENDENCIES = host-pkgconf
+
+$(eval $(autotools-package))