diff mbox

cjson: bug fix - use -fPIC instead of -fpic

Message ID 1346119086-3465-1-git-send-email-danomimanchego123@gmail.com
State Accepted
Headers show

Commit Message

Danomi Manchego Aug. 28, 2012, 1:58 a.m. UTC
This change is to fix the autobuild failure at:
http://autobuild.buildroot.net/results/45e2c08d5e3c868b2d7fdf26a7c5f88de5ff8f61/build-end.log
I can't actually reproduce this bug, because my machine cannot
run the 64-bit microblaze toolchain.  However, the log makes
it clear that -fPIC is needed, and grepping for fPIC and fpic
under packages makes it clear that cjson should have used -fPIC
anyway.  So even if the bug isn't fixed, it must surely be improved.

Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
---
 package/cjson/cjson.mk |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Peter Korsgaard Sept. 6, 2012, 8:12 p.m. UTC | #1
>>>>> "Danomi" == Danomi Manchego <danomimanchego123@gmail.com> writes:

 Danomi> This change is to fix the autobuild failure at:
 Danomi> http://autobuild.buildroot.net/results/45e2c08d5e3c868b2d7fdf26a7c5f88de5ff8f61/build-end.log
 Danomi> I can't actually reproduce this bug, because my machine cannot
 Danomi> run the 64-bit microblaze toolchain.  However, the log makes
 Danomi> it clear that -fPIC is needed, and grepping for fPIC and fpic
 Danomi> under packages makes it clear that cjson should have used -fPIC
 Danomi> anyway.  So even if the bug isn't fixed, it must surely be improved.

Sounds similar to the recent libpcap fix. Committed, thanks.
diff mbox

Patch

diff --git a/package/cjson/cjson.mk b/package/cjson/cjson.mk
index 6f26bb8..a2de8ab 100644
--- a/package/cjson/cjson.mk
+++ b/package/cjson/cjson.mk
@@ -14,7 +14,7 @@  define CJSON_EXTRACT_CMDS
 endef
 
 define CJSON_BUILD_CMDS
-	cd $(@D)/cJSON && $(TARGET_CC) $(TARGET_CFLAGS) -shared -fpic cJSON.c -o libcJSON.so
+	cd $(@D)/cJSON && $(TARGET_CC) $(TARGET_CFLAGS) -shared -fPIC cJSON.c -o libcJSON.so
 endef
 
 define CJSON_INSTALL_STAGING_CMDS