From patchwork Tue Jul 10 17:37:22 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nathan Lynch X-Patchwork-Id: 170255 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (silver.osuosl.org [140.211.166.136]) by ozlabs.org (Postfix) with ESMTP id 19E6A2C0080 for ; Wed, 11 Jul 2012 03:37:39 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 6D47A31F1C; Tue, 10 Jul 2012 17:37:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U2y7uu6+MwI2; Tue, 10 Jul 2012 17:37:34 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id E449631CC5; Tue, 10 Jul 2012 17:37:33 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id E18EB8F75B for ; Tue, 10 Jul 2012 17:37:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id D96338D169 for ; Tue, 10 Jul 2012 17:37:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6u1RQXNosSfq for ; Tue, 10 Jul 2012 17:37:27 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from sasl.smtp.pobox.com (a-pb-sasl-sd.pobox.com [74.115.168.62]) by whitealder.osuosl.org (Postfix) with ESMTP id 675368D15E for ; Tue, 10 Jul 2012 17:37:27 +0000 (UTC) Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by b-pb-sasl-sd.pobox.com (Postfix) with ESMTP id 81040A641 for ; Tue, 10 Jul 2012 13:37:24 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to :subject:date:message-id; s=sasl; bh=57GSXqU8NivzuoHxNyb+tFPAvr4 =; b=RUt8kDP72BnYjbAfwN0OhEOAfJg/v7tn0Lsx3fe0tgMAAfRU1RAItbw6+DM 8lWbS0PjALld9qyA5LbHhjA+ZAJiiO06y2UjvaThoTOZWsVevWXBLpVpWnXuM31K rlzC1GzUeb29wQWvMjyfKFLQzlenv2nVjuAscOjyfEPLLKAs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:subject :date:message-id; q=dns; s=sasl; b=JmtX8bOFVOwIxWphD5NEGq2T/uBet Xf0u8JtbzPbqsn8KyGHdu9CAHesgBMxDN6vkcbvKRvz25Pc2RoYenowEadViFJs6 m8j9quhkrduil3SPr19lRxwESgZfcVTYctPtxVj/3n68Fh8CfD7xJ47jpxLWLUey j884nvonqeLlYQ= Received: from b-pb-sasl-sd. (unknown [127.0.0.1]) by b-pb-sasl-sd.pobox.com (Postfix) with ESMTP id 78850A640 for ; Tue, 10 Jul 2012 13:37:24 -0400 (EDT) Received: from orca.stoopid.dyndns.org (unknown [99.12.192.254]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by b-pb-sasl-sd.pobox.com (Postfix) with ESMTPSA id D957FA63F for ; Tue, 10 Jul 2012 13:37:23 -0400 (EDT) From: Nathan Lynch To: buildroot@busybox.net Date: Tue, 10 Jul 2012 12:37:22 -0500 Message-Id: <1341941842-22303-1-git-send-email-ntl@pobox.com> X-Mailer: git-send-email 1.7.10.4 X-Pobox-Relay-ID: E8B3558C-CAB5-11E1-830B-FA6787E41631-04752483!b-pb-sasl-sd.pobox.com Subject: [Buildroot] [PATCH] unexport TERMINFO to correct ncurses behavior X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net The ncurses build can become polluted by the user's TERMINFO environment variable, causing the user's ~/.terminfo to be modified and preventing the install from succeeding: /bin/sh ./run_tic.sh ** Building terminfo database, please wait... Running tic to install /home/nathanl/devel/buildroot.git/output/host/usr/i686-unknown-linux-gnu/sysroot/usr/share/emacs/24.0.97/etc/ ... You may see messages regarding extended capabilities, e.g., AX. These are extended terminal capabilities which are compiled using tic -x If you have ncurses 4.2 applications, you should read the INSTALL document, and install the terminfo without the -x option. 1562 entries written to /home/nathanl/.terminfo ** built new /home/nathanl/devel/buildroot.git/output/host/usr/i686-unknown-linux-gnu/sysroot/usr/share/emacs/24.0.97/etc/ installing std installing stdcrt installing vt100 installing vt300 make[2]: Leaving directory `/home/nathanl/devel/buildroot.git/output/build/ncurses-5.7/misc' make[1]: Leaving directory `/home/nathanl/devel/buildroot.git/output/build/ncurses-5.7' for i in $(find /home/nathanl/devel/buildroot.git/output/host/usr/i686-unknown-linux-gnu/sysroot/usr/lib* -name "*.la"); do cp -f $i $i~; /usr/bin/sed -i -e "s:\(['= ]\)/usr:\\1/home/nathanl/devel/buildroot.git/output/host/usr/i686-unknown-linux-gnu/sysroot/usr:g" $i; done >>> ncurses 5.7 Installing to target mkdir -p /home/nathanl/devel/buildroot.git/output/target/usr/lib cp -dpf /home/nathanl/devel/buildroot.git/output/build/ncurses-5.7/lib/libncurses.so* /home/nathanl/devel/buildroot.git/output/target/usr/lib/ ln -snf /usr/share/terminfo /home/nathanl/devel/buildroot.git/output/target/usr/lib/terminfo mkdir -p /home/nathanl/devel/buildroot.git/output/target/usr/share/terminfo/x cp -dpf /home/nathanl/devel/buildroot.git/output/host/usr/i686-unknown-linux-gnu/sysroot/usr/share/terminfo/x/xterm /home/nathanl/devel/buildroot.git/output/target/usr/share/terminfo/x cp: cannot stat `/home/nathanl/devel/buildroot.git/output/host/usr/i686-unknown-linux-gnu/sysroot/usr/share/terminfo/x/xterm': No such file or directory make: *** [/home/nathanl/devel/buildroot.git/output/build/ncurses-5.7/.stamp_target_installed] Error 1 So unexport TERMINFO in the top-level Makefile. Signed-off-by: Nathan Lynch Acked-by: Gustavo Zacarias --- Noticed this when building in emacs ansi-term. The following defconfig is enough to recreate it: BR2_x86_i686=y BR2_TOOLCHAIN_EXTERNAL=y # BR2_PACKAGE_BUSYBOX is not set BR2_PACKAGE_NCURSES=y Verified that menuconfig still works; is there anything else I should check? Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index b80477f..6ec7a57 100644 --- a/Makefile +++ b/Makefile @@ -199,6 +199,7 @@ unexport CFLAGS unexport CXXFLAGS unexport GREP_OPTIONS unexport CONFIG_SITE +unexport TERMINFO GNU_HOST_NAME:=$(shell support/gnuconfig/config.guess)