| Message ID | 20181117182007.14791-6-martin.blumenstingl@googlemail.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | IP101GR: devicetree based configuration of SEL_INTR32 | expand |
On Sat, Nov 17, 2018 at 07:20:05PM +0100, Martin Blumenstingl wrote: > The datasheet uses the name "All Mask" for this bit. Change the name of > our #define to be consistent with the datasheet. While here also replace > the tab between the #define and IP101A_G_IRQ_ALL_MASK with a space. > No functional changes. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> I think this is the bit which confused Florian. Nice change, it makes it a lot clearer what is going on. Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
diff --git a/drivers/net/phy/icplus.c b/drivers/net/phy/icplus.c index 3ec470adde3d..c9489ec77cef 100644 --- a/drivers/net/phy/icplus.c +++ b/drivers/net/phy/icplus.c @@ -43,7 +43,7 @@ MODULE_LICENSE("GPL"); #define IP101A_G_APS_ON BIT(1) /* IP101A/G APS Mode bit */ #define IP101A_G_IRQ_CONF_STATUS 0x11 /* Conf Info IRQ & Status Reg */ #define IP101A_G_IRQ_PIN_USED BIT(15) /* INTR pin used */ -#define IP101A_G_NO_IRQ BIT(11) /* IRQ's inactive */ +#define IP101A_G_IRQ_ALL_MASK BIT(11) /* IRQ's inactive */ static int ip175c_config_init(struct phy_device *phydev) { @@ -204,7 +204,7 @@ static int ip101a_g_config_intr(struct phy_device *phydev) /* INTR pin used: Speed/link/duplex will cause an interrupt */ val = IP101A_G_IRQ_PIN_USED; else - val = IP101A_G_NO_IRQ; + val = IP101A_G_IRQ_ALL_MASK; return phy_write(phydev, IP101A_G_IRQ_CONF_STATUS, val); }
The datasheet uses the name "All Mask" for this bit. Change the name of our #define to be consistent with the datasheet. While here also replace the tab between the #define and IP101A_G_IRQ_ALL_MASK with a space. No functional changes. Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- drivers/net/phy/icplus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)