pinctrl: mediatek: Convert to using %pOFn instead of device_node.name
diff mbox series

Message ID 20181116220540.17222-4-robh@kernel.org
State New
Headers show
Series
  • pinctrl: mediatek: Convert to using %pOFn instead of device_node.name
Related show

Commit Message

Rob Herring Nov. 16, 2018, 10:05 p.m. UTC
In preparation to remove the node name pointer from struct device_node,
convert printf users to use the %pOFn format specifier.

Cc: Sean Wang <sean.wang@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-mediatek@lists.infradead.org
Cc: linux-gpio@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
 drivers/pinctrl/mediatek/pinctrl-paris.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Sean Wang Nov. 16, 2018, 11:46 p.m. UTC | #1
On Fri, Nov 16, 2018 at 2:06 PM Rob Herring <robh@kernel.org> wrote:
>
> In preparation to remove the node name pointer from struct device_node,
> convert printf users to use the %pOFn format specifier.
>
> Cc: Sean Wang <sean.wang@kernel.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Cc: linux-mediatek@lists.infradead.org
> Cc: linux-gpio@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Rob Herring <robh@kernel.org>

Acked-by: Sean Wang <sean.wang@kernel.org>

> ---
>  drivers/pinctrl/mediatek/pinctrl-paris.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c
> index d2179028f134..7ff5ffa88198 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-paris.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c
> @@ -419,8 +419,8 @@ static int mtk_pctrl_dt_subnode_to_map(struct pinctrl_dev *pctldev,
>
>         pins = of_find_property(node, "pinmux", NULL);
>         if (!pins) {
> -               dev_err(hw->dev, "missing pins property in node %s .\n",
> -                       node->name);
> +               dev_err(hw->dev, "missing pins property in node %pOFn .\n",
> +                       node);
>                 return -EINVAL;
>         }
>
> --
> 2.19.1
>
Linus Walleij Nov. 19, 2018, 2:14 p.m. UTC | #2
On Fri, Nov 16, 2018 at 11:06 PM Rob Herring <robh@kernel.org> wrote:

> In preparation to remove the node name pointer from struct device_node,
> convert printf users to use the %pOFn format specifier.
>
> Cc: Sean Wang <sean.wang@kernel.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Cc: linux-mediatek@lists.infradead.org
> Cc: linux-gpio@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Rob Herring <robh@kernel.org>

Patch applied with Sean's ACK.

Yours,
Linus Walleij
Rob Herring Nov. 19, 2018, 7:07 p.m. UTC | #3
On Fri, Nov 16, 2018 at 5:46 PM Sean Wang <sean.wang@kernel.org> wrote:
>
> On Fri, Nov 16, 2018 at 2:06 PM Rob Herring <robh@kernel.org> wrote:
> >
> > In preparation to remove the node name pointer from struct device_node,
> > convert printf users to use the %pOFn format specifier.
> >
> > Cc: Sean Wang <sean.wang@kernel.org>
> > Cc: Linus Walleij <linus.walleij@linaro.org>
> > Cc: Matthias Brugger <matthias.bgg@gmail.com>
> > Cc: linux-mediatek@lists.infradead.org
> > Cc: linux-gpio@vger.kernel.org
> > Cc: linux-arm-kernel@lists.infradead.org
> > Signed-off-by: Rob Herring <robh@kernel.org>
>
> Acked-by: Sean Wang <sean.wang@kernel.org>

BTW, messages to you bounce:

<sean.wang@mediatek.com> (expanded from <sean.wang@kernel.org>): host
    mailgw01.mediatek.com[216.200.240.184] said: 550 Relaying mail to
    sean.wang@mediatek.com is not allowed (in reply to RCPT TO command)

Perhaps you need your kernel.org account to route somewhere else.

Rob
Sean Wang Nov. 19, 2018, 7:26 p.m. UTC | #4
On Mon, Nov 19, 2018 at 11:07 AM Rob Herring <robh@kernel.org> wrote:
>
> On Fri, Nov 16, 2018 at 5:46 PM Sean Wang <sean.wang@kernel.org> wrote:
> >
> > On Fri, Nov 16, 2018 at 2:06 PM Rob Herring <robh@kernel.org> wrote:
> > >
> > > In preparation to remove the node name pointer from struct device_node,
> > > convert printf users to use the %pOFn format specifier.
> > >
> > > Cc: Sean Wang <sean.wang@kernel.org>
> > > Cc: Linus Walleij <linus.walleij@linaro.org>
> > > Cc: Matthias Brugger <matthias.bgg@gmail.com>
> > > Cc: linux-mediatek@lists.infradead.org
> > > Cc: linux-gpio@vger.kernel.org
> > > Cc: linux-arm-kernel@lists.infradead.org
> > > Signed-off-by: Rob Herring <robh@kernel.org>
> >
> > Acked-by: Sean Wang <sean.wang@kernel.org>
>
> BTW, messages to you bounce:
>
> <sean.wang@mediatek.com> (expanded from <sean.wang@kernel.org>): host
>     mailgw01.mediatek.com[216.200.240.184] said: 550 Relaying mail to
>     sean.wang@mediatek.com is not allowed (in reply to RCPT TO command)
>
> Perhaps you need your kernel.org account to route somewhere else.
>
> Rob

Thanks. I've found the issue. Will fix it soon.

Patch
diff mbox series

diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c
index d2179028f134..7ff5ffa88198 100644
--- a/drivers/pinctrl/mediatek/pinctrl-paris.c
+++ b/drivers/pinctrl/mediatek/pinctrl-paris.c
@@ -419,8 +419,8 @@  static int mtk_pctrl_dt_subnode_to_map(struct pinctrl_dev *pctldev,
 
 	pins = of_find_property(node, "pinmux", NULL);
 	if (!pins) {
-		dev_err(hw->dev, "missing pins property in node %s .\n",
-			node->name);
+		dev_err(hw->dev, "missing pins property in node %pOFn .\n",
+			node);
 		return -EINVAL;
 	}