[v2] Update mount.cifs with vers=default mount option and SMBv3.02

Message ID 20181116112736.16666-1-kdsouza@redhat.com
State New
Headers show
Series
  • [v2] Update mount.cifs with vers=default mount option and SMBv3.02
Related show

Commit Message

Kenneth Dsouza Nov. 16, 2018, 11:27 a.m.
Signed-off-by: Kenneth D'souza <kdsouza@redhat.com>
---
 mount.cifs.rst | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Tom Talpey Nov. 16, 2018, 3:44 p.m. | #1
> -----Original Message-----
> From: linux-cifs-owner@vger.kernel.org <linux-cifs-owner@vger.kernel.org> On
> Behalf Of Kenneth D'souza
> Sent: Friday, November 16, 2018 3:28 AM
> To: linux-cifs@vger.kernel.org
> Cc: piastryyy@gmail.com; smfrench@gmail.com
> Subject: [PATCH v2] Update mount.cifs with vers=default mount option and
> SMBv3.02
> 
> Signed-off-by: Kenneth D'souza <kdsouza@redhat.com>
> ---
>  mount.cifs.rst | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/mount.cifs.rst b/mount.cifs.rst
> index 405c459..afcf27b 100644
> --- a/mount.cifs.rst
> +++ b/mount.cifs.rst
> @@ -543,6 +543,11 @@ vers=arg
>    - 2.1 - The SMBv2.1 protocol that was introduced in Microsoft Windows 7
> and Windows Server 2008R2.
>    - 3.0 - The SMBv3.0 protocol that was introduced in Microsoft Windows 8
> and Windows Server 2012.
>    - 3.1.1 or 3.11 - The SMBv3.1.1 protocol that was introduced in Microsoft
> Windows Server 2016.
> +  - 3.0.2 or 3.02 - The SMBv3.02 protocol that was introduced in Windows
> 8.1(Windows 'Blue') and Windows Server 2012 R2.
> +  - default - Tries to negotiate the highest SMB2+ version supported by the
> server.

Wait, this drops the 3.1.1 dialect option, which should certainly remain! BTW, 3.1.1 is supported in Windows starting in Windows 10 (any version) and Windows Server 2016 (as already noted above). And the canonical name of the dialect is "3.0.2", the "3.02" is a legacy Samba naming thing, so I'd suggest "SMBv3.0.2" in the text for consistency. Rest looks good.

Tom.

> +
> +   If no dialect is specified on mount vers=default is used.
> +   To check ``Dialect`` refer to /proc/fs/cifs/DebugData
> 
>    Note too that while this option governs the protocol version used, not
>    all features of each version are available.
> --
> 2.17.2
Kenneth Dsouza Nov. 17, 2018, 5:13 a.m. | #2
Thanks for the feedback, I will do the necessary changes in V3.
On Fri, Nov 16, 2018 at 9:14 PM Tom Talpey <ttalpey@microsoft.com> wrote:
>
> > -----Original Message-----
> > From: linux-cifs-owner@vger.kernel.org <linux-cifs-owner@vger.kernel.org> On
> > Behalf Of Kenneth D'souza
> > Sent: Friday, November 16, 2018 3:28 AM
> > To: linux-cifs@vger.kernel.org
> > Cc: piastryyy@gmail.com; smfrench@gmail.com
> > Subject: [PATCH v2] Update mount.cifs with vers=default mount option and
> > SMBv3.02
> >
> > Signed-off-by: Kenneth D'souza <kdsouza@redhat.com>
> > ---
> >  mount.cifs.rst | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/mount.cifs.rst b/mount.cifs.rst
> > index 405c459..afcf27b 100644
> > --- a/mount.cifs.rst
> > +++ b/mount.cifs.rst
> > @@ -543,6 +543,11 @@ vers=arg
> >    - 2.1 - The SMBv2.1 protocol that was introduced in Microsoft Windows 7
> > and Windows Server 2008R2.
> >    - 3.0 - The SMBv3.0 protocol that was introduced in Microsoft Windows 8
> > and Windows Server 2012.
> >    - 3.1.1 or 3.11 - The SMBv3.1.1 protocol that was introduced in Microsoft
> > Windows Server 2016.
> > +  - 3.0.2 or 3.02 - The SMBv3.02 protocol that was introduced in Windows
> > 8.1(Windows 'Blue') and Windows Server 2012 R2.
> > +  - default - Tries to negotiate the highest SMB2+ version supported by the
> > server.
>
> Wait, this drops the 3.1.1 dialect option, which should certainly remain! BTW, 3.1.1 is supported in Windows starting in Windows 10 (any version) and Windows Server 2016 (as already noted above). And the canonical name of the dialect is "3.0.2", the "3.02" is a legacy Samba naming thing, so I'd suggest "SMBv3.0.2" in the text for consistency. Rest looks good.
>
> Tom.
>
> > +
> > +   If no dialect is specified on mount vers=default is used.
> > +   To check ``Dialect`` refer to /proc/fs/cifs/DebugData
> >
> >    Note too that while this option governs the protocol version used, not
> >    all features of each version are available.
> > --
> > 2.17.2
>

Patch

diff --git a/mount.cifs.rst b/mount.cifs.rst
index 405c459..afcf27b 100644
--- a/mount.cifs.rst
+++ b/mount.cifs.rst
@@ -543,6 +543,11 @@  vers=arg
   - 2.1 - The SMBv2.1 protocol that was introduced in Microsoft Windows 7 and Windows Server 2008R2.
   - 3.0 - The SMBv3.0 protocol that was introduced in Microsoft Windows 8 and Windows Server 2012.
   - 3.1.1 or 3.11 - The SMBv3.1.1 protocol that was introduced in Microsoft Windows Server 2016.
+  - 3.0.2 or 3.02 - The SMBv3.02 protocol that was introduced in Windows 8.1(Windows 'Blue') and Windows Server 2012 R2.
+  - default - Tries to negotiate the highest SMB2+ version supported by the server.
+
+   If no dialect is specified on mount vers=default is used.
+   To check ``Dialect`` refer to /proc/fs/cifs/DebugData
 
   Note too that while this option governs the protocol version used, not
   all features of each version are available.