From patchwork Fri Jun 10 12:17:05 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Aneesh Kumar K.V" X-Patchwork-Id: 99888 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 944D5B6FAC for ; Fri, 10 Jun 2011 22:27:57 +1000 (EST) Received: from localhost ([::1]:57357 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QV0oa-00021q-De for incoming@patchwork.ozlabs.org; Fri, 10 Jun 2011 08:27:52 -0400 Received: from eggs.gnu.org ([140.186.70.92]:41353) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QV0eM-0000RP-F0 for qemu-devel@nongnu.org; Fri, 10 Jun 2011 08:17:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QV0eK-000745-B2 for qemu-devel@nongnu.org; Fri, 10 Jun 2011 08:17:18 -0400 Received: from e5.ny.us.ibm.com ([32.97.182.145]:35033) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QV0eK-00073w-1g for qemu-devel@nongnu.org; Fri, 10 Jun 2011 08:17:16 -0400 Received: from d01relay06.pok.ibm.com (d01relay06.pok.ibm.com [9.56.227.116]) by e5.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p5ABnW7P020142 for ; Fri, 10 Jun 2011 07:49:32 -0400 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p5ACHEhn1355948 for ; Fri, 10 Jun 2011 08:17:14 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p5ACHD2m025818 for ; Fri, 10 Jun 2011 08:17:13 -0400 Received: from skywalker.linux.vnet.ibm.com ([9.126.238.158]) by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p5ACH88C025360; Fri, 10 Jun 2011 08:17:10 -0400 From: "Aneesh Kumar K.V" To: "Edgar E. Iglesias" , qemu-devel@nongnu.org In-Reply-To: <20110610101233.GB13549@edde.se.axis.com> References: <20110610101233.GB13549@edde.se.axis.com> User-Agent: Notmuch/0.5-215-g5143e5e (http://notmuchmail.org) Emacs/23.2.1 (i686-pc-linux-gnu) Date: Fri, 10 Jun 2011 17:47:05 +0530 Message-ID: <87vcwdev9a.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Received-From: 32.97.182.145 Subject: Re: [Qemu-devel] fsdev - broken qemu-system-? X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On Fri, 10 Jun 2011 12:12:33 +0200, "Edgar E. Iglesias" wrote: > At least CRIS, Microblaze and lm32 are broken on latest git. Things fail with > the following message: > qemu-system-cris: there is no option group "fsdev" > > Under GDB I see a segfault... > > % gdb --args ~/src/c/qemu/git/build-qemu/cris-softmmu/qemu-system-cris -M axis-dev88 -kernel kimage -serial stdio > GNU gdb (Gentoo 7.2 p1) 7.2 > Copyright (C) 2010 Free Software Foundation, Inc. > License GPLv3+: GNU GPL version 3 or later > This is free software: you are free to change and redistribute it. > There is NO WARRANTY, to the extent permitted by law. Type "show copying" > and "show warranty" for details. > This GDB was configured as "x86_64-pc-linux-gnu". > For bug reporting instructions, please see: > ... > Reading symbols from /home/edgar/src/c/qemu/git/build-qemu/cris-softmmu/qemu-system-cris...done. > (gdb) run > Starting program: /home/edgar/src/c/qemu/git/build-qemu/cris-softmmu/qemu-system-cris -M axis-dev88 -kernel kimage -serial stdio > [Thread debugging using libthread_db enabled] > qemu-system-cris: there is no option group "fsdev" > > Program received signal SIGSEGV, Segmentation fault. > qemu_opts_foreach (list=0x0, func=0x4fd210 , opaque=0x0, > abort_on_failure=1) at /home/edgar/src/c/qemu/git/qemu/qemu-option.c:969 > 969 QTAILQ_FOREACH(opts, &list->head, next) { > (gdb) bt > #0 qemu_opts_foreach (list=0x0, func=0x4fd210 , opaque=0x0, > abort_on_failure=1) at /home/edgar/src/c/qemu/git/qemu/qemu-option.c:969 > #1 0x00000000004ff05d in main (argc=7, argv=0x7fffffffdc28, > envp=) at /home/edgar/src/c/qemu/git/qemu/vl.c:3015 > (gdb) q > A debugging session is active. > > Inferior 1 [process 1473] will be killed. > Can you try this patch diff --git a/fsdev/qemu-fsdev-dummy.c b/fsdev/qemu-fsdev-dummy.c index 619e163..4e700dd 100644 --- a/fsdev/qemu-fsdev-dummy.c +++ b/fsdev/qemu-fsdev-dummy.c @@ -13,8 +13,16 @@ #include #include #include "qemu-fsdev.h" +#include "qemu-config.h" int qemu_fsdev_add(QemuOpts *opts) { return 0; } + +static void fsdev_register_config(void) +{ + qemu_add_opts(&qemu_fsdev_opts); + qemu_add_opts(&qemu_virtfs_opts); +} +machine_init(fsdev_register_config);