Message ID | 20181116104229.20181-1-dalvarez@redhat.com |
---|---|
State | Accepted |
Headers | show |
Series | [ovs-dev] netdev: Add comment to allow removing a workaround in the future | expand |
On Fri, Nov 16, 2018 at 11:42:29AM +0100, Daniel Alvarez wrote: > This patch [0] in glibc fixes an issue which is right now workarounded > in OVS by [1]. I'm adding a comment to indicate that from glibc 2.28 > and beyond, the workaround is not needed so that we can eventually > remove it. > > [0] https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c1f86a33ca32e26a9d6e29fc961e5ecb5e2e5eb4 > [1] https://github.com/openvswitch/ovs/commit/3434d306866d825084d2d186d1f8dd98662ff650 > > Signed-off-by: Daniel Alvarez <dalvarez@redhat.com> Thanks, applied to master.
diff --git a/lib/netdev.c b/lib/netdev.c index 84874408a..45b50f26c 100644 --- a/lib/netdev.c +++ b/lib/netdev.c @@ -2063,7 +2063,8 @@ retry: * address addition which may cause one of the returned * ifa_name values to be NULL. In such case, we know that we've * got an inconsistent dump. Retry but beware of an endless - * loop. */ + * loop. From glibc 2.28 and beyond, this workaround is not + * needed and should be eventually removed. */ freeifaddrs(if_addr_list); goto retry; } else {
This patch [0] in glibc fixes an issue which is right now workarounded in OVS by [1]. I'm adding a comment to indicate that from glibc 2.28 and beyond, the workaround is not needed so that we can eventually remove it. [0] https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c1f86a33ca32e26a9d6e29fc961e5ecb5e2e5eb4 [1] https://github.com/openvswitch/ovs/commit/3434d306866d825084d2d186d1f8dd98662ff650 Signed-off-by: Daniel Alvarez <dalvarez@redhat.com> --- lib/netdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.17.2