From patchwork Fri Jun 10 08:03:14 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Hellstrom X-Patchwork-Id: 99881 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4482FB700E for ; Fri, 10 Jun 2011 20:55:56 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755728Ab1FJKzq (ORCPT ); Fri, 10 Jun 2011 06:55:46 -0400 Received: from mail176c2.megamailservers.com ([69.49.111.76]:43243 "EHLO mail176c2.megamailservers.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755715Ab1FJKzn (ORCPT ); Fri, 10 Jun 2011 06:55:43 -0400 X-Greylist: delayed 10340 seconds by postgrey-1.27 at vger.kernel.org; Fri, 10 Jun 2011 06:55:43 EDT X-Authenticated-User: daniel.gaisler.com Received: from [192.168.0.47] (gaisler.se [92.33.28.242]) (authenticated bits=0) by mail176c2.megamailservers.com (8.13.6/8.13.1) with ESMTP id p5A83K1m031663 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 10 Jun 2011 04:03:22 -0400 Message-ID: <4DF1CFC2.5080101@gaisler.com> Date: Fri, 10 Jun 2011 10:03:14 +0200 From: Daniel Hellstrom User-Agent: Mozilla Thunderbird 1.0.6 (X11/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: netdev@vger.kernel.org Subject: CRC endianess problem on DGE-510T X-CSC: 0 X-CHA: v=1.1 cv=7GFoO/wu22Xu7f+7cd9V9wY/biOPJIupRAMVre9JRXg= c=1 sm=1 a=pl2ZPvC6udcA:10 a=BbvArhnn50sA:10 a=U62ajLuCel8A:10 a=8nJEP1OIZ-IA:10 a=jXKJviUpWSOlMmIvGrHOfw==:17 a=ebG-ZW-8AAAA:8 a=jFpZE2hjMyM_Ictats4A:9 a=wPNLvfGTeEIA:10 a=cCYF7-FHeg4A:10 a=jXKJviUpWSOlMmIvGrHOfw==:117 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello, I'm having problems with the PCI network board D-LINK DGE-510T on SPARC32/LEON. The CRC calculated by ether_crc_le() does not match the CRC, however after swapping the result it matches. This is the same behaviour with the 3 boards I have. After applying the patch below everything works. Does anyone know if this is a correct patch or has had similar problems on big endian machines? Daniel From: Daniel Hellstrom Date: Wed, 6 Apr 2011 15:01:44 +0200 [PATCH] dl2k: EEPROM CRC calculation wrong endianess on bigendian machine Signed-off-by: Daniel Hellstrom --- drivers/net/dl2k.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- 1.5.4 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/dl2k.c b/drivers/net/dl2k.c index c445457..4bbbd7b 100644 --- a/drivers/net/dl2k.c +++ b/drivers/net/dl2k.c @@ -346,7 +346,7 @@ parse_eeprom (struct net_device *dev) if (np->pdev->vendor == PCI_VENDOR_ID_DLINK) { /* D-Link Only */ /* Check CRC */ crc = ~ether_crc_le (256 - 4, sromdata); - if (psrom->crc != crc) { + if (psrom->crc != cpu_to_le32(crc)) {q printk (KERN_ERR "%s: EEPROM data CRC error.\n", dev->name); return -1;