[v2] u-boot: Add mkenvimage tool

Message ID 20181115124339.19543-1-abrodkin@synopsys.com
State New
Headers show
Series
  • [v2] u-boot: Add mkenvimage tool
Related show

Commit Message

Alexey Brodkin Nov. 15, 2018, 12:43 p.m.
This utility is used for creation of images containing
usable in run-time U-Boot environment.

Note it is already gets built with "make tools" command
together with "mkimage" so we just need to install "mkenvimage".

As of today this utility is added per-board like here [1]
for Intel Edison board.

[1] http://git.yoctoproject.org/cgit/cgit.cgi/meta-intel-edison/tree/meta-intel-edison-bsp/recipes-bsp/u-boot/u-boot-tools_2014.04.bb

Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: Otavio Salvador <otavio@ossystems.com.br>
Cc: Martin Jansa <martin.jansa@gmail.com>
Cc: Ross Burton <ross.burton@intel.com>
Cc: Marek Vasut <marex@denx.de>
---

Chnages v1 -> v2:

 * Got rid of a separate recipe and instead added mkenvimage
   to u-boot mkimage recipy

 meta/recipes-bsp/u-boot/u-boot-mkimage_2018.07.bb | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

Comments

Marek Vasut Nov. 15, 2018, 1:43 p.m. | #1
On 11/15/2018 01:43 PM, Alexey Brodkin wrote:
> This utility is used for creation of images containing
> usable in run-time U-Boot environment.
> 
> Note it is already gets built with "make tools" command
> together with "mkimage" so we just need to install "mkenvimage".
> 
> As of today this utility is added per-board like here [1]
> for Intel Edison board.
> 
> [1] http://git.yoctoproject.org/cgit/cgit.cgi/meta-intel-edison/tree/meta-intel-edison-bsp/recipes-bsp/u-boot/u-boot-tools_2014.04.bb
> 
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Richard Purdie <richard.purdie@linuxfoundation.org>
> Cc: Otavio Salvador <otavio@ossystems.com.br>
> Cc: Martin Jansa <martin.jansa@gmail.com>
> Cc: Ross Burton <ross.burton@intel.com>
> Cc: Marek Vasut <marex@denx.de>
> ---
> 
> Chnages v1 -> v2:
> 
>  * Got rid of a separate recipe and instead added mkenvimage
>    to u-boot mkimage recipy
> 
>  meta/recipes-bsp/u-boot/u-boot-mkimage_2018.07.bb | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-bsp/u-boot/u-boot-mkimage_2018.07.bb b/meta/recipes-bsp/u-boot/u-boot-mkimage_2018.07.bb
> index 08bff1d161..8a8a1ed449 100644
> --- a/meta/recipes-bsp/u-boot/u-boot-mkimage_2018.07.bb
> +++ b/meta/recipes-bsp/u-boot/u-boot-mkimage_2018.07.bb
> @@ -1,6 +1,6 @@
>  require u-boot-common_${PV}.inc
>  
> -SUMMARY = "U-Boot bootloader image creation tool"
> +SUMMARY = "U-Boot bootloader environment & image creation tools"
>  DEPENDS += "openssl"
>  
>  EXTRA_OEMAKE_class-target = 'CROSS_COMPILE="${TARGET_PREFIX}" CC="${CC} ${CFLAGS} ${LDFLAGS}" HOSTCC="${BUILD_CC} ${BUILD_CFLAGS} ${BUILD_LDFLAGS}" STRIP=true V=1'
> @@ -20,8 +20,14 @@ do_compile () {
>  
>  do_install () {
>  	install -d ${D}${bindir}
> +
> +	# mkimage
>  	install -m 0755 tools/mkimage ${D}${bindir}/uboot-mkimage
>  	ln -sf uboot-mkimage ${D}${bindir}/mkimage
> +
> +	# mkenvimage
> +	install -m 0755 tools/mkenvimage ${D}${bindir}/uboot-mkenvimage
> +	ln -sf uboot-mkenvimage ${D}${bindir}/mkenvimage
>  }
>  
>  RDEPENDS_${PN} += "dtc"

I have to admit, the recipe name becomes a misnomer then. But renaming
this recipe would be hard, since it's used all over the place. Any ideas?
Burton, Ross Nov. 15, 2018, 3 p.m. | #2
On Thu, 15 Nov 2018 at 14:50, Marek Vasut <marex@denx.de> wrote:
> I have to admit, the recipe name becomes a misnomer then. But renaming
> this recipe would be hard, since it's used all over the place. Any ideas?

Call it u-boot-tools, potentially merge the other recipe tool, and add
RPROVIDES for compatibility?

Ross
Marek Vasut Nov. 15, 2018, 3:06 p.m. | #3
On 11/15/2018 04:00 PM, Burton, Ross wrote:
> On Thu, 15 Nov 2018 at 14:50, Marek Vasut <marex@denx.de> wrote:
>> I have to admit, the recipe name becomes a misnomer then. But renaming
>> this recipe would be hard, since it's used all over the place. Any ideas?
> 
> Call it u-boot-tools, potentially merge the other recipe tool, and add
> RPROVIDES for compatibility?

Ah :-)

I wonder if it'd make sense to have this new recipe generate multiple
packages, one per tool ?
Richard Purdie Nov. 15, 2018, 3:12 p.m. | #4
On Thu, 2018-11-15 at 15:00 +0000, Burton, Ross wrote:
> On Thu, 15 Nov 2018 at 14:50, Marek Vasut <marex@denx.de> wrote:
> > I have to admit, the recipe name becomes a misnomer then. But
> > renaming
> > this recipe would be hard, since it's used all over the place. Any
> > ideas?
> 
> Call it u-boot-tools, potentially merge the other recipe tool, and
> add
> RPROVIDES for compatibility?

You mean PROVIDES since we're talking PN namespace, not PACKAGES?

Cheers,

Richard

Patch

diff --git a/meta/recipes-bsp/u-boot/u-boot-mkimage_2018.07.bb b/meta/recipes-bsp/u-boot/u-boot-mkimage_2018.07.bb
index 08bff1d161..8a8a1ed449 100644
--- a/meta/recipes-bsp/u-boot/u-boot-mkimage_2018.07.bb
+++ b/meta/recipes-bsp/u-boot/u-boot-mkimage_2018.07.bb
@@ -1,6 +1,6 @@ 
 require u-boot-common_${PV}.inc
 
-SUMMARY = "U-Boot bootloader image creation tool"
+SUMMARY = "U-Boot bootloader environment & image creation tools"
 DEPENDS += "openssl"
 
 EXTRA_OEMAKE_class-target = 'CROSS_COMPILE="${TARGET_PREFIX}" CC="${CC} ${CFLAGS} ${LDFLAGS}" HOSTCC="${BUILD_CC} ${BUILD_CFLAGS} ${BUILD_LDFLAGS}" STRIP=true V=1'
@@ -20,8 +20,14 @@  do_compile () {
 
 do_install () {
 	install -d ${D}${bindir}
+
+	# mkimage
 	install -m 0755 tools/mkimage ${D}${bindir}/uboot-mkimage
 	ln -sf uboot-mkimage ${D}${bindir}/mkimage
+
+	# mkenvimage
+	install -m 0755 tools/mkenvimage ${D}${bindir}/uboot-mkenvimage
+	ln -sf uboot-mkenvimage ${D}${bindir}/mkenvimage
 }
 
 RDEPENDS_${PN} += "dtc"