| Message ID | 1542249210-6396-1-git-send-email-gromero@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b2fed34a628df6118b5d4e13f49a33e15f704fa9 |
| Headers | show |
| Series | [v2] selftests/powerpc: Adjust wild_bctr to build with old gcc | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | next/apply_patch Successfully applied |
| snowpatch_ozlabs/build-ppc64le | success | build succeded & removed 0 sparse warning(s) |
| snowpatch_ozlabs/build-ppc64be | success | build succeded & removed 0 sparse warning(s) |
| snowpatch_ozlabs/build-ppc64e | success | build succeded & removed 0 sparse warning(s) |
| snowpatch_ozlabs/build-pmac32 | success | build succeded & removed 0 sparse warning(s) |
| snowpatch_ozlabs/checkpatch | warning | total: 0 errors, 1 warnings, 2 checks, 10 lines checked |
On Thu, 2018-11-15 at 02:33:30 UTC, Gustavo Romero wrote: > Currently the selftest wild_bctr can fail to build when an old gcc is used, > notably on gcc using a binutils version <= 2.27, because the assembler does > not support the integer suffix UL. > > This patch adjusts the wild_bctr test so the REG_POISON value is still > treated as an unsigned long for the shifts on compilation but the UL > suffix is absent on the stringification, so the inline asm code generated > has no UL suffixes. > > Signed-off-by: Gustavo Romero <gromero@linux.vnet.ibm.com> Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/b2fed34a628df6118b5d4e13f49a33 cheers
diff --git a/tools/testing/selftests/powerpc/mm/wild_bctr.c b/tools/testing/selftests/powerpc/mm/wild_bctr.c index 90469a9..aadac172 100644 --- a/tools/testing/selftests/powerpc/mm/wild_bctr.c +++ b/tools/testing/selftests/powerpc/mm/wild_bctr.c @@ -47,8 +47,8 @@ static int ok(void) return 0; } -#define REG_POISON 0x5a5aUL -#define POISONED_REG(n) ((REG_POISON << 48) | ((n) << 32) | (REG_POISON << 16) | (n)) +#define REG_POISON 0x5a5a +#define POISONED_REG(n) ((((unsigned long) REG_POISON) << 48) | ((n) << 32) | (((unsigned long) REG_POISON) << 16) | (n)) static inline void poison_regs(void) {
Currently the selftest wild_bctr can fail to build when an old gcc is used, notably on gcc using a binutils version <= 2.27, because the assembler does not support the integer suffix UL. This patch adjusts the wild_bctr test so the REG_POISON value is still treated as an unsigned long for the shifts on compilation but the UL suffix is absent on the stringification, so the inline asm code generated has no UL suffixes. Signed-off-by: Gustavo Romero <gromero@linux.vnet.ibm.com> --- tools/testing/selftests/powerpc/mm/wild_bctr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)