+reminder+ Don’t build gdb/readline/libreadline.a, when --with-system-readline is supplied
diff mbox series

Message ID ce3e6a9574b44250053ea1a226801dd5211870fa.camel@aegee.org
State New
Headers show
Series
  • +reminder+ Don’t build gdb/readline/libreadline.a, when --with-system-readline is supplied
Related show

Commit Message

Дилян Палаузов Nov. 14, 2018, 9:28 p.m. UTC
-------- Forwarded Message --------
From: Дилян Палаузов <dilyan.palauzov@aegee.org>
To: gcc-patches@gcc.gnu.org
Subject: Don’t build gdb/readline/libreadline.a, when --with-system-
readline is supplied
Date: Sat, 27 Oct 2018 19:53:44 +0000

Building GDB always builds the bundled libreadline.a, even if use of
the libreadline installed on the system was requested with --with-
system-readline.

The change below is for binutils-gdb’s/configure.ac, which is
maintained by gcc.


See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87741 [GCC] and 
https://sourceware.org/bugzilla/show_bug.cgi?id=18632 [GDB] for
details.

Patch
diff mbox series

diff --git a/configure.ac b/configure.ac
--- a/configure.ac
+++ b/configure.ac
@@ -253,6 +253,12 @@  if test x$with_system_zlib = xyes ; then
   noconfigdirs="$noconfigdirs zlib"
 fi
 
+# Don't compile the bundled readline/libreadline.a in gdb-binutils if
+#  --with-system-readline is provided.
+if test x$with_system_readline = xyes ; then
+  noconfigdirs="$noconfigdirs readline"
+fi
+
 # some tools are so dependent upon X11 that if we're not building with
X, 
 # it's not even worth trying to configure, much less build, that tool.