| Message ID | 20181114170249.19966-1-fbarrat@linux.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] platform/witherspoon: Avoid harmless error message | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | master/apply_patch Successfully applied |
| snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot | success | Test snowpatch/job/snowpatch-skiboot on branch master |
On 15/11/18 4:02 am, Frederic Barrat wrote: > The I2C read to find out if a device on the GPU slot is an opencapi > adapter or nvidia card is reporting an "arbitration loss" error if no > device is connected on the GPU slot. That I2C read is actually useless > if we already know there's no device connected, so let's skip it. It > will avoid logging an harmless error. > > Signed-off-by: Frederic Barrat <fbarrat@linux.ibm.com> Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com> Stewart - can we get this in for v6.2?
Andrew Donnellan <andrew.donnellan@au1.ibm.com> writes: > On 15/11/18 4:02 am, Frederic Barrat wrote: >> The I2C read to find out if a device on the GPU slot is an opencapi >> adapter or nvidia card is reporting an "arbitration loss" error if no >> device is connected on the GPU slot. That I2C read is actually useless >> if we already know there's no device connected, so let's skip it. It >> will avoid logging an harmless error. >> >> Signed-off-by: Frederic Barrat <fbarrat@linux.ibm.com> > > Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com> > > Stewart - can we get this in for v6.2? Yep, just going over the 6.2-rc1 release notes now. These patches made it.
Frederic Barrat <fbarrat@linux.ibm.com> writes: > The I2C read to find out if a device on the GPU slot is an opencapi > adapter or nvidia card is reporting an "arbitration loss" error if no > device is connected on the GPU slot. That I2C read is actually useless > if we already know there's no device connected, so let's skip it. It > will avoid logging an harmless error. Thankks! Series merged to master as of cdaa6d1b26142e647c4e074b0a6d5837ed503c0d
diff --git a/platforms/astbmc/witherspoon.c b/platforms/astbmc/witherspoon.c index f45f739f..772a7199 100644 --- a/platforms/astbmc/witherspoon.c +++ b/platforms/astbmc/witherspoon.c @@ -271,6 +271,13 @@ static void witherspoon_npu2_device_detect(struct npu2 *npu) prlog(PR_DEBUG, "PLAT: Chip %d GPU#1 slot present\n", chip->id); } + /* + * The following I2C ops generate errors if no device is + * present on any SXM2 slot. Since it's useless, let's skip it + */ + if (!gpu0_present && !gpu1_present) + return; + /* Set pins to input */ state = 0xff; rc = i2c_request_send(i2c_port_id,
The I2C read to find out if a device on the GPU slot is an opencapi adapter or nvidia card is reporting an "arbitration loss" error if no device is connected on the GPU slot. That I2C read is actually useless if we already know there's no device connected, so let's skip it. It will avoid logging an harmless error. Signed-off-by: Frederic Barrat <fbarrat@linux.ibm.com> --- platforms/astbmc/witherspoon.c | 7 +++++++ 1 file changed, 7 insertions(+)