| Message ID | 20181114131627.17766-2-narmstrong@baylibre.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [v2,1/3] dt-bindings: amlogic: Add Internal Clock Measurer bindings | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | "total: 0 errors, 1 warnings, 15 lines checked" |
On Wed, 14 Nov 2018 14:16:25 +0100, Neil Armstrong wrote: > The Amlogic Meson GX SoCs embeds a clock measurer IP to measure the internal > clock paths frequencies. > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > --- > .../bindings/soc/amlogic/clk-measure.txt | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/amlogic/clk-measure.txt > Reviewed-by: Rob Herring <robh@kernel.org>
Hi Neil, On Wed, Nov 14, 2018 at 2:16 PM Neil Armstrong <narmstrong@baylibre.com> wrote: > > The Amlogic Meson GX SoCs embeds a clock measurer IP to measure the internal > clock paths frequencies. I would skip the "GX" in that sentence: there's a similar (identical?) clock measurer in Meson6, Meson8, Meson8b and Meson8m2 as well > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> with the comment above and below: Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > --- > .../bindings/soc/amlogic/clk-measure.txt | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/amlogic/clk-measure.txt > > diff --git a/Documentation/devicetree/bindings/soc/amlogic/clk-measure.txt b/Documentation/devicetree/bindings/soc/amlogic/clk-measure.txt > new file mode 100644 > index 000000000000..ba9183a42032 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/amlogic/clk-measure.txt > @@ -0,0 +1,15 @@ > +Amlogic Internal Clock Measurer > +=============================== > + > +The Amlogic SoCs contains an IP to measure the internal clocks. > +The precision is multiple of MHz, useful to debug the clock states. > + > +Required properties: > +- compatible: Shall contain "amlogic,meson-gx-clk-measure" can you please add "amlogic,meson8-clk-measure" and "amlogic,meson8b-clk-measure" as well? (I will provide a patch on top of yours to add Meson8 and Meson8b support) Regards Martin
diff --git a/Documentation/devicetree/bindings/soc/amlogic/clk-measure.txt b/Documentation/devicetree/bindings/soc/amlogic/clk-measure.txt new file mode 100644 index 000000000000..ba9183a42032 --- /dev/null +++ b/Documentation/devicetree/bindings/soc/amlogic/clk-measure.txt @@ -0,0 +1,15 @@ +Amlogic Internal Clock Measurer +=============================== + +The Amlogic SoCs contains an IP to measure the internal clocks. +The precision is multiple of MHz, useful to debug the clock states. + +Required properties: +- compatible: Shall contain "amlogic,meson-gx-clk-measure" +- reg: base address and size of the Clock Measurer register space. + +Example: + clock-measure@8758 { + compatible = "amlogic,meson-gx-clk-measure"; + reg = <0x0 0x8758 0x0 0x10>; + };
The Amlogic Meson GX SoCs embeds a clock measurer IP to measure the internal clock paths frequencies. Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- .../bindings/soc/amlogic/clk-measure.txt | 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/amlogic/clk-measure.txt