| Message ID | 20181114121642.1404-2-peron.clem@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | None | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Wed, Nov 14, 2018 at 01:16:42PM +0100, Clément Péron wrote: > Document the bindings for AK4118 S/PDIF transceiver > > Signed-off-by: Clément Péron <peron.clem@gmail.com> > --- > .../devicetree/bindings/sound/ak4118.txt | 22 +++++++++++++++++++ > 1 file changed, 22 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/ak4118.txt > > diff --git a/Documentation/devicetree/bindings/sound/ak4118.txt b/Documentation/devicetree/bindings/sound/ak4118.txt > new file mode 100644 > index 000000000000..6e11a2f7404c > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/ak4118.txt > @@ -0,0 +1,22 @@ > +AK4118 S/PDIF transceiver > + > +This device supports I2C mode. > + > +Required properties: > + > +- compatible : "asahi-kasei,ak4118" > +- reg : The I2C address of the device for I2C > +- reset-gpios: A GPIO specifier for the reset pin > +- irq-gpios: A GPIO specifier for the IRQ pin This should use 'interrupts' instead. > + > +Example: > + > +&i2c { > + ak4118: ak4118@13 { spdif@13 ? Node names should be based on the class of device, but there's not really one defined for this. > + #sound-dai-cells = <0>; > + compatible = "asahi-kasei,ak4118"; > + reg = <0x13>; > + reset-gpios = <&gpio 0 GPIO_ACTIVE_LOW> > + irq-gpios = <&gpio 1 GPIO_ACTIVE_HIGH>; > + }; > +}; > -- > 2.19.1 >
Hi Rob, On Sat, 17 Nov 2018 at 16:51, Rob Herring <robh@kernel.org> wrote: > > On Wed, Nov 14, 2018 at 01:16:42PM +0100, Clément Péron wrote: > > Document the bindings for AK4118 S/PDIF transceiver > > > > Signed-off-by: Clément Péron <peron.clem@gmail.com> > > --- > > .../devicetree/bindings/sound/ak4118.txt | 22 +++++++++++++++++++ > > 1 file changed, 22 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/sound/ak4118.txt > > > > diff --git a/Documentation/devicetree/bindings/sound/ak4118.txt b/Documentation/devicetree/bindings/sound/ak4118.txt > > new file mode 100644 > > index 000000000000..6e11a2f7404c > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/sound/ak4118.txt > > @@ -0,0 +1,22 @@ > > +AK4118 S/PDIF transceiver > > + > > +This device supports I2C mode. > > + > > +Required properties: > > + > > +- compatible : "asahi-kasei,ak4118" > > +- reg : The I2C address of the device for I2C > > +- reset-gpios: A GPIO specifier for the reset pin > > +- irq-gpios: A GPIO specifier for the IRQ pin > > This should use 'interrupts' instead. Yes, this will also simplify the driver. > > > + > > +Example: > > + > > +&i2c { > > + ak4118: ak4118@13 { > > spdif@13 ? Node names should be based on the class of device, but > there's not really one defined for this. Ok I will use spdif. Thanks for the comments, Clement > > > + #sound-dai-cells = <0>; > > + compatible = "asahi-kasei,ak4118"; > > + reg = <0x13>; > > + reset-gpios = <&gpio 0 GPIO_ACTIVE_LOW> > > + irq-gpios = <&gpio 1 GPIO_ACTIVE_HIGH>; > > + }; > > +}; > > -- > > 2.19.1 > >
diff --git a/Documentation/devicetree/bindings/sound/ak4118.txt b/Documentation/devicetree/bindings/sound/ak4118.txt new file mode 100644 index 000000000000..6e11a2f7404c --- /dev/null +++ b/Documentation/devicetree/bindings/sound/ak4118.txt @@ -0,0 +1,22 @@ +AK4118 S/PDIF transceiver + +This device supports I2C mode. + +Required properties: + +- compatible : "asahi-kasei,ak4118" +- reg : The I2C address of the device for I2C +- reset-gpios: A GPIO specifier for the reset pin +- irq-gpios: A GPIO specifier for the IRQ pin + +Example: + +&i2c { + ak4118: ak4118@13 { + #sound-dai-cells = <0>; + compatible = "asahi-kasei,ak4118"; + reg = <0x13>; + reset-gpios = <&gpio 0 GPIO_ACTIVE_LOW> + irq-gpios = <&gpio 1 GPIO_ACTIVE_HIGH>; + }; +};
Document the bindings for AK4118 S/PDIF transceiver Signed-off-by: Clément Péron <peron.clem@gmail.com> --- .../devicetree/bindings/sound/ak4118.txt | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/ak4118.txt