From patchwork Thu Jun 9 12:01:15 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Bader X-Patchwork-Id: 99739 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id D1A99B6FDE for ; Thu, 9 Jun 2011 22:01:43 +1000 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1QUdvO-0001OF-Ds; Thu, 09 Jun 2011 12:01:22 +0000 Received: from adelie.canonical.com ([91.189.90.139]) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1QUdvM-0001N2-5w for kernel-team@lists.ubuntu.com; Thu, 09 Jun 2011 12:01:20 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by adelie.canonical.com with esmtp (Exim 4.71 #1 (Debian)) id 1QUdvJ-0003iv-7F for ; Thu, 09 Jun 2011 12:01:17 +0000 Received: from p5b2e5361.dip.t-dialin.net ([91.46.83.97] helo=[192.168.2.5]) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QUdvJ-00048N-21 for kernel-team@lists.ubuntu.com; Thu, 09 Jun 2011 12:01:17 +0000 Message-ID: <4DF0B60B.1050508@canonical.com> Date: Thu, 09 Jun 2011 14:01:15 +0200 From: Stefan Bader User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110516 Lightning/1.0b2 Thunderbird/3.1.10 MIME-Version: 1.0 To: Ubuntu Kernel Team Subject: [Hardy] SRU: Disable COMPAT_VDSO for custom xen i386 builds X-Enigmail-Version: 1.1.2 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.13 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kernel-team-bounces@lists.ubuntu.com Errors-To: kernel-team-bounces@lists.ubuntu.com SRU Justification: Impact: The COMPAT_VDSO option will cause the VDSO segment (32bit) to appear also at its old, non-randomized place. It is only required for older libc versions. 10.04 already is at a newer level and the generic build has it turned off. Fix: Turn the option off for the custom-binary-xen (i386) build as well. Testcase: QA regression testing will fail with this option turned on. Verified it is running successfully in a Hardy VM using the -xen kernel in dom0, as well as running it as domU on EC2 (m1.small). -Stefan Acked-by: Andy Whitcroft Acked-by: Tim Gardner From a24326982bdf55584b1a1c119dbd26bc5979877e Mon Sep 17 00:00:00 2001 From: Stefan Bader Date: Thu, 9 Jun 2011 13:53:58 +0200 Subject: [PATCH] UBUNTU: (config) Disable COMPAT_VDSO for i386 Xen kernels BugLink: http://bugs.launchpad.net/bugs/794715 This option is already disabled for generic i386 kernels as it practically renders randomization of the VDSO location useless. According to the description of this option it only is needed for older (<2.3.3) versions of libc. As the Hardy version is newer than that, it makes no sense to keep it enabled. Signed-off-by: Stefan Bader --- debian/binary-custom.d/xen/config.i386 | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/debian/binary-custom.d/xen/config.i386 b/debian/binary-custom.d/xen/config.i386 index c387aa5..72758e9 100644 --- a/debian/binary-custom.d/xen/config.i386 +++ b/debian/binary-custom.d/xen/config.i386 @@ -241,7 +241,7 @@ CONFIG_CRASH_DUMP=y CONFIG_PHYSICAL_START=0x100000 CONFIG_PHYSICAL_ALIGN=0x100000 CONFIG_HOTPLUG_CPU=y -CONFIG_COMPAT_VDSO=y +# CONFIG_COMPAT_VDSO is not set CONFIG_ARCH_ENABLE_MEMORY_HOTPLUG=y # -- 1.7.4.1