| Message ID | 20181113082823.2440-4-aik@ozlabs.ru (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | powerpc/powernv/npu, vfio: NVIDIA V100 + P9 passthrough | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | warning | next/apply_patch Patch failed to apply |
| snowpatch_ozlabs/apply_patch | fail | Failed to apply to any branch |
On Tue, Nov 13, 2018 at 07:28:04PM +1100, Alexey Kardashevskiy wrote: > Since we are going to have 2 different preregistering helpers, let's > make it clear that mm_iommu_new() is only for the normal memory > (i.e.not device memory) and for existing areas mm_iommu_get() should be > used instead. > > This removes the check for exact match as the check for overlap is > enough now. > > Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru> Reviewed-by: David Gibson <david@gibson.dropbear.id.au> It would make sense to fold this into the previous patch, I think, but it's not worth doing a respin just for that. > --- > Changes: > v2: > * remove the exact match check > --- > arch/powerpc/mm/mmu_context_iommu.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/arch/powerpc/mm/mmu_context_iommu.c b/arch/powerpc/mm/mmu_context_iommu.c > index babc6ad..580d89e 100644 > --- a/arch/powerpc/mm/mmu_context_iommu.c > +++ b/arch/powerpc/mm/mmu_context_iommu.c > @@ -102,12 +102,6 @@ long mm_iommu_new(struct mm_struct *mm, unsigned long ua, unsigned long entries, > > list_for_each_entry_rcu(mem, &mm->context.iommu_group_mem_list, > next) { > - if ((mem->ua == ua) && (mem->entries == entries)) { > - ++mem->used; > - *pmem = mem; > - goto unlock_exit; > - } > - > /* Overlap? */ > if ((mem->ua < (ua + (entries << PAGE_SHIFT))) && > (ua < (mem->ua +
diff --git a/arch/powerpc/mm/mmu_context_iommu.c b/arch/powerpc/mm/mmu_context_iommu.c index babc6ad..580d89e 100644 --- a/arch/powerpc/mm/mmu_context_iommu.c +++ b/arch/powerpc/mm/mmu_context_iommu.c @@ -102,12 +102,6 @@ long mm_iommu_new(struct mm_struct *mm, unsigned long ua, unsigned long entries, list_for_each_entry_rcu(mem, &mm->context.iommu_group_mem_list, next) { - if ((mem->ua == ua) && (mem->entries == entries)) { - ++mem->used; - *pmem = mem; - goto unlock_exit; - } - /* Overlap? */ if ((mem->ua < (ua + (entries << PAGE_SHIFT))) && (ua < (mem->ua +
Since we are going to have 2 different preregistering helpers, let's make it clear that mm_iommu_new() is only for the normal memory (i.e.not device memory) and for existing areas mm_iommu_get() should be used instead. This removes the check for exact match as the check for overlap is enough now. Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru> --- Changes: v2: * remove the exact match check --- arch/powerpc/mm/mmu_context_iommu.c | 6 ------ 1 file changed, 6 deletions(-)