From patchwork Thu Jun 9 09:04:46 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [06/30] UBIFS: minor cleanup: use S_ISREG helper Date: Wed, 08 Jun 2011 23:04:46 -0000 From: Artem Bityutskiy X-Patchwork-Id: 99681 Message-Id: <1307610310-28691-7-git-send-email-dedekind1@gmail.com> To: linux-mtd@lists.infradead.org From: Artem Bityutskiy Instead of using long "(inode->i_mode & S_IFMT) != S_IFREG" expression, use shorted "!S_ISREG(inode->i_mode)". Signed-off-by: Artem Bityutskiy --- fs/ubifs/super.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c index 55161c6..70e8c92 100644 --- a/fs/ubifs/super.c +++ b/fs/ubifs/super.c @@ -85,7 +85,7 @@ static int validate_inode(struct ubifs_info *c, const struct inode *inode) if (ui->data_len < 0 || ui->data_len > UBIFS_MAX_INO_DATA) return 4; - if (ui->xattr && (inode->i_mode & S_IFMT) != S_IFREG) + if (ui->xattr && !S_ISREG(inode->i_mode)) return 5; if (!ubifs_compr_present(ui->compr_type)) {