diff mbox series

[3/4] dt-bindings: rtc: sd3078: add device tree documentation

Message ID 1542001514-8167-3-git-send-email-long17.cool@163.com
State Superseded
Headers show
Series [1/4] dt-bindings: define vendor prefix for whwave, Inc. | expand

Commit Message

zoro Nov. 12, 2018, 5:45 a.m. UTC
The devicetree documentation for the SD3078 device tree
binding is added with a short example.

Signed-off-by: zoro <long17.cool@163.com>
---
 .../devicetree/bindings/rtc/rtc-sd3078.txt         |   15 +++++++++++++++
 MAINTAINERS                                        |    1 +
 2 files changed, 16 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/rtc/rtc-sd3078.txt

Comments

Alexandre Belloni Nov. 12, 2018, 3:49 p.m. UTC | #1
This patch should come as 2/4 (BTW, I never got 4/4)

On 12/11/2018 13:45:14+0800, zoro wrote:
> The devicetree documentation for the SD3078 device tree
> binding is added with a short example.
> 
> Signed-off-by: zoro <long17.cool@163.com>
> ---
>  .../devicetree/bindings/rtc/rtc-sd3078.txt         |   15 +++++++++++++++
>  MAINTAINERS                                        |    1 +
>  2 files changed, 16 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/rtc/rtc-sd3078.txt
> 
> diff --git a/Documentation/devicetree/bindings/rtc/rtc-sd3078.txt b/Documentation/devicetree/bindings/rtc/rtc-sd3078.txt
> new file mode 100644
> index 0000000..9b45c8e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/rtc-sd3078.txt
> @@ -0,0 +1,15 @@
> +SD3078 Real Time Clock
> +============================
> +
> +Required properties:
> +- compatible: Should contain "whwave,sd3078".
> +- reg: I2C address for chip.
> +
> +Example:
> +
> +sd3078: sd3078@32 {
> +       compatible = "whwave,sd3078";
> +       reg = <0x32>;
> +};
> +
> +
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 002fcd7..50c038d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -16130,6 +16130,7 @@ M:	Zoro Li <long17.cool@163.com>
>  L:	linux-rtc@vger.kernel.org
>  S:	Maintained
>  F:	drivers/rtc/rtc-sd3078.c
> +F:	Documentation/devicetree/bindings/rtc/rtc-sd3078.txt
>  

There is no need to list this file here if it is only done to silence
checkpatch.

>  WIIMOTE HID DRIVER
>  M:	David Herrmann <dh.herrmann@googlemail.com>
> -- 
> 1.7.9.5
> 
>
Alexandre Belloni Nov. 12, 2018, 5:40 p.m. UTC | #2
On 13/11/2018 00:55:49+0800, long17.cool@163.com wrote:
> helloļ¼š
> The patch of 4/4 is not used for this modules,  this is my problem.
> 
> I have a question : 
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -16130,6 +16130,7 @@ M: Zoro Li <long17.cool@163.com>
> >  L: linux-rtc@vger.kernel.org
> >  S: Maintained
> >  F: drivers/rtc/rtc-sd3078.c
> > +F: Documentation/devicetree/bindings/rtc/rtc-sd3078.txt
> > 
> 
> There is no need to list this file here if it is only done to silence checkpatch.
> What does it mean?
> 
> I found that if I didn't add that statement, when I checkpatch,
>  I would get the following warning.
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #16: 
> new file mode 100644
> Can I ignore this warning?
> 

Yes, you can.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/rtc/rtc-sd3078.txt b/Documentation/devicetree/bindings/rtc/rtc-sd3078.txt
new file mode 100644
index 0000000..9b45c8e
--- /dev/null
+++ b/Documentation/devicetree/bindings/rtc/rtc-sd3078.txt
@@ -0,0 +1,15 @@ 
+SD3078 Real Time Clock
+============================
+
+Required properties:
+- compatible: Should contain "whwave,sd3078".
+- reg: I2C address for chip.
+
+Example:
+
+sd3078: sd3078@32 {
+       compatible = "whwave,sd3078";
+       reg = <0x32>;
+};
+
+
diff --git a/MAINTAINERS b/MAINTAINERS
index 002fcd7..50c038d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -16130,6 +16130,7 @@  M:	Zoro Li <long17.cool@163.com>
 L:	linux-rtc@vger.kernel.org
 S:	Maintained
 F:	drivers/rtc/rtc-sd3078.c
+F:	Documentation/devicetree/bindings/rtc/rtc-sd3078.txt
 
 WIIMOTE HID DRIVER
 M:	David Herrmann <dh.herrmann@googlemail.com>