snapcraft: update confinement and plugs
diff mbox series

Message ID 20181109135306.22228-1-colin.king@canonical.com
State Accepted
Headers show
Series
  • snapcraft: update confinement and plugs
Related show

Commit Message

Colin King Nov. 9, 2018, 1:53 p.m. UTC
From: Colin Ian King <colin.king@canonical.com>

Make confinement strict and add in the required plugs for the tool
to work correctly.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 snapcraft.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Alex Hung Nov. 13, 2018, 7:07 a.m. UTC | #1
On 2018-11-09 9:53 p.m., Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Make confinement strict and add in the required plugs for the tool
> to work correctly.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  snapcraft.yaml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/snapcraft.yaml b/snapcraft.yaml
> index 4ecc2037..8cd9768f 100644
> --- a/snapcraft.yaml
> +++ b/snapcraft.yaml
> @@ -2,7 +2,7 @@ name: fwts
>  version: V18.09.00
>  summary: The Firmware Test Suite (FWTS)
>  description: This is a firmware test suite that performs sanity checks on system firmware. It is intended to identify BIOS and ACPI errors and if appropriate it will try to explain the errors and give advice to help workaround or fix firmware bugs.  It is primarily intended to be a Linux-centric firmware troubleshooting tool.
> -confinement: devmode
> +confinement: strict
>  
>  parts:
>      fwts:
> @@ -27,6 +27,7 @@ parts:
>              - libbsd-dev
>  apps:
>      fwts:
> +        plugs: [home, hardware-observe, io-ports-control, kernel-module-control, log-observe, system-observe ]
>          command: bin/fwts
>          environment:
>              LD_LIBRARY_PATH: $LD_LIBRARY_PATH:$SNAP/lib/fwts
> 

Acked-by: Alex Hung <alex.hung@canonical.com>
ivanhu Nov. 13, 2018, 7:53 a.m. UTC | #2
On 11/9/18 9:53 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Make confinement strict and add in the required plugs for the tool
> to work correctly.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  snapcraft.yaml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/snapcraft.yaml b/snapcraft.yaml
> index 4ecc2037..8cd9768f 100644
> --- a/snapcraft.yaml
> +++ b/snapcraft.yaml
> @@ -2,7 +2,7 @@ name: fwts
>  version: V18.09.00
>  summary: The Firmware Test Suite (FWTS)
>  description: This is a firmware test suite that performs sanity checks on system firmware. It is intended to identify BIOS and ACPI errors and if appropriate it will try to explain the errors and give advice to help workaround or fix firmware bugs.  It is primarily intended to be a Linux-centric firmware troubleshooting tool.
> -confinement: devmode
> +confinement: strict
>  
>  parts:
>      fwts:
> @@ -27,6 +27,7 @@ parts:
>              - libbsd-dev
>  apps:
>      fwts:
> +        plugs: [home, hardware-observe, io-ports-control, kernel-module-control, log-observe, system-observe ]
>          command: bin/fwts
>          environment:
>              LD_LIBRARY_PATH: $LD_LIBRARY_PATH:$SNAP/lib/fwts

Acked-by: Ivan Hu <ivan.hu@canonical.com>

Patch
diff mbox series

diff --git a/snapcraft.yaml b/snapcraft.yaml
index 4ecc2037..8cd9768f 100644
--- a/snapcraft.yaml
+++ b/snapcraft.yaml
@@ -2,7 +2,7 @@  name: fwts
 version: V18.09.00
 summary: The Firmware Test Suite (FWTS)
 description: This is a firmware test suite that performs sanity checks on system firmware. It is intended to identify BIOS and ACPI errors and if appropriate it will try to explain the errors and give advice to help workaround or fix firmware bugs.  It is primarily intended to be a Linux-centric firmware troubleshooting tool.
-confinement: devmode
+confinement: strict
 
 parts:
     fwts:
@@ -27,6 +27,7 @@  parts:
             - libbsd-dev
 apps:
     fwts:
+        plugs: [home, hardware-observe, io-ports-control, kernel-module-control, log-observe, system-observe ]
         command: bin/fwts
         environment:
             LD_LIBRARY_PATH: $LD_LIBRARY_PATH:$SNAP/lib/fwts