[ovs-dev,1/3] nroff: Increase width for .IP used for ordered lists.

Message ID 20181109053955.28951-1-blp@ovn.org
State Accepted
Headers show
Series
  • [ovs-dev,1/3] nroff: Increase width for .IP used for ordered lists.
Related show

Commit Message

Ben Pfaff Nov. 9, 2018, 5:39 a.m.
The ordered lists that a .25in width produced looked OK in PostScript
or PDF output, but in text output every list item spanned two lines,
like this:

   1.
     First list item.
   2.
     Second list item.

With this change, they appear normally:

   1. First list item.
   2. Second list item.

Signed-off-by: Ben Pfaff <blp@ovn.org>
---
 python/build/nroff.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Michelson Jan. 10, 2019, 8:09 p.m. | #1
Hi Ben,

Excellent new document. This will be great to have in the code.

For the series
Acked-by: Mark Michelson <mmichels@redhat.com>

On 11/9/18 12:39 AM, Ben Pfaff wrote:
> The ordered lists that a .25in width produced looked OK in PostScript
> or PDF output, but in text output every list item spanned two lines,
> like this:
> 
>     1.
>       First list item.
>     2.
>       Second list item.
> 
> With this change, they appear normally:
> 
>     1. First list item.
>     2. Second list item.
> 
> Signed-off-by: Ben Pfaff <blp@ovn.org>
> ---
>   python/build/nroff.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/python/build/nroff.py b/python/build/nroff.py
> index 73353061cccc..17ff69bfe47a 100644
> --- a/python/build/nroff.py
> +++ b/python/build/nroff.py
> @@ -316,7 +316,7 @@ def block_xml_to_nroff(nodes, para='.PP'):
>                           if node.tagName == 'ul':
>                               s += ".IP \\(bu\n"
>                           else:
> -                            s += ".IP %d. .25in\n" % i
> +                            s += ".IP %d. .4in\n" % i
>                           s += block_xml_to_nroff(li_node.childNodes, ".IP")
>                       elif li_node.nodeType == node.COMMENT_NODE:
>                           pass
>
Ben Pfaff Jan. 10, 2019, 11:52 p.m. | #2
Thank you for the review.  I applied this series to master.

On Thu, Jan 10, 2019 at 03:09:44PM -0500, Mark Michelson wrote:
> Hi Ben,
> 
> Excellent new document. This will be great to have in the code.
> 
> For the series
> Acked-by: Mark Michelson <mmichels@redhat.com>
> 
> On 11/9/18 12:39 AM, Ben Pfaff wrote:
> > The ordered lists that a .25in width produced looked OK in PostScript
> > or PDF output, but in text output every list item spanned two lines,
> > like this:
> > 
> >     1.
> >       First list item.
> >     2.
> >       Second list item.
> > 
> > With this change, they appear normally:
> > 
> >     1. First list item.
> >     2. Second list item.
> > 
> > Signed-off-by: Ben Pfaff <blp@ovn.org>
> > ---
> >   python/build/nroff.py | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/python/build/nroff.py b/python/build/nroff.py
> > index 73353061cccc..17ff69bfe47a 100644
> > --- a/python/build/nroff.py
> > +++ b/python/build/nroff.py
> > @@ -316,7 +316,7 @@ def block_xml_to_nroff(nodes, para='.PP'):
> >                           if node.tagName == 'ul':
> >                               s += ".IP \\(bu\n"
> >                           else:
> > -                            s += ".IP %d. .25in\n" % i
> > +                            s += ".IP %d. .4in\n" % i
> >                           s += block_xml_to_nroff(li_node.childNodes, ".IP")
> >                       elif li_node.nodeType == node.COMMENT_NODE:
> >                           pass
> > 
>

Patch

diff --git a/python/build/nroff.py b/python/build/nroff.py
index 73353061cccc..17ff69bfe47a 100644
--- a/python/build/nroff.py
+++ b/python/build/nroff.py
@@ -316,7 +316,7 @@  def block_xml_to_nroff(nodes, para='.PP'):
                         if node.tagName == 'ul':
                             s += ".IP \\(bu\n"
                         else:
-                            s += ".IP %d. .25in\n" % i
+                            s += ".IP %d. .4in\n" % i
                         s += block_xml_to_nroff(li_node.childNodes, ".IP")
                     elif li_node.nodeType == node.COMMENT_NODE:
                         pass