diff mbox

[net-next] iph: use default get_stats

Message ID 20110608110913.54becfba@nehalam.ftrdhcpuser.net
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

stephen hemminger June 8, 2011, 6:09 p.m. UTC 
This driver keeps stats in net_device stats therefore it
does not need to define it's own get_stats hook.

Also, use standard format for net_device_ops (without &).

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

David Miller June 9, 2011, 12:06 a.m. UTC | #1 
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed, 8 Jun 2011 11:09:13 -0700

> This driver keeps stats in net_device stats therefore it
> does not need to define it's own get_stats hook.
> 
> Also, use standard format for net_device_ops (without &).
> 
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

--- a/drivers/net/usb/ipheth.c	2011-05-12 08:39:09.000000000 -0700
+++ b/drivers/net/usb/ipheth.c	2011-06-08 11:03:50.011606145 -0700
@@ -409,12 +409,6 @@  static void ipheth_tx_timeout(struct net
 	usb_unlink_urb(dev->tx_urb);
 }
 
-static struct net_device_stats *ipheth_stats(struct net_device *net)
-{
-	struct ipheth_device *dev = netdev_priv(net);
-	return &dev->net->stats;
-}
-
 static u32 ipheth_ethtool_op_get_link(struct net_device *net)
 {
 	struct ipheth_device *dev = netdev_priv(net);
@@ -426,11 +420,10 @@  static struct ethtool_ops ops = {
 };
 
 static const struct net_device_ops ipheth_netdev_ops = {
-	.ndo_open = &ipheth_open,
-	.ndo_stop = &ipheth_close,
-	.ndo_start_xmit = &ipheth_tx,
-	.ndo_tx_timeout = &ipheth_tx_timeout,
-	.ndo_get_stats = &ipheth_stats,
+	.ndo_open = ipheth_open,
+	.ndo_stop = ipheth_close,
+	.ndo_start_xmit = ipheth_tx,
+	.ndo_tx_timeout = ipheth_tx_timeout,
 };
 
 static int ipheth_probe(struct usb_interface *intf,