[3/3] gpio: mockup: implement get_multiple()

Message ID 20181108165255.9940-4-brgl@bgdev.pl
State New
Headers show
Series
  • gpio: mockup: misc updates
Related show

Commit Message

Bartosz Golaszewski Nov. 8, 2018, 4:52 p.m.
We already support set_multiple(). Implement get_multiple() as well.

Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
---
 drivers/gpio/gpio-mockup.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

Comments

Uwe Kleine-König Nov. 8, 2018, 8:36 p.m. | #1
On Thu, Nov 08, 2018 at 05:52:55PM +0100, Bartosz Golaszewski wrote:
> We already support set_multiple(). Implement get_multiple() as well.
> 
> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>

Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Linus Walleij Nov. 16, 2018, 9:44 p.m. | #2
On Thu, Nov 8, 2018 at 5:53 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:

> We already support set_multiple(). Implement get_multiple() as well.
>
> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>

Waiting to see how I should apply patch 1+2 but all looks
good to me!

Yours,
Linus Walleij

Patch

diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
index 3cd92912c414..a4c054cf9c5f 100644
--- a/drivers/gpio/gpio-mockup.c
+++ b/drivers/gpio/gpio-mockup.c
@@ -102,6 +102,22 @@  static int gpio_mockup_get(struct gpio_chip *gc, unsigned int offset)
 	return val;
 }
 
+static int gpio_mockup_get_multiple(struct gpio_chip *gc,
+				    unsigned long *mask, unsigned long *bits)
+{
+	struct gpio_mockup_chip *chip = gpiochip_get_data(gc);
+	unsigned int bit, val;
+
+	mutex_lock(&chip->lock);
+	for_each_set_bit(bit, mask, gc->ngpio) {
+		val = __gpio_mockup_get(gc, bit);
+		__assign_bit(bit, bits, val);
+	}
+	mutex_unlock(&chip->lock);
+
+	return 0;
+}
+
 static void __gpio_mockup_set(struct gpio_chip *gc,
 			      unsigned int offset, int value)
 {
@@ -327,6 +343,7 @@  static int gpio_mockup_probe(struct platform_device *pdev)
 	gc->parent = dev;
 	gc->get = gpio_mockup_get;
 	gc->set = gpio_mockup_set;
+	gc->get_multiple = gpio_mockup_get_multiple;
 	gc->set_multiple = gpio_mockup_set_multiple;
 	gc->direction_output = gpio_mockup_dirout;
 	gc->direction_input = gpio_mockup_dirin;