From patchwork Thu Nov 8 12:28:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aldy Hernandez X-Patchwork-Id: 994842 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-489353-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="jczL0gHy"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42rMyD4DPKz9sBN for ; Thu, 8 Nov 2018 23:28:20 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; q=dns; s=default; b=GO5UgDQS23Tn0ac7q6Sg9/Rws9r8ly2HXX3YuancWg85aSI6Sa hRP8O1UmgPgaM9107/wubOXyf56GYBMtp4iaFCL/cHRrMWS9nhdupyJRW8Zeq/LZ nObH2JvhzGiiEIM7RGp8R+zgPEtfVYZPpvILPYjcqPPGMRFw+QlIIZryk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; s= default; bh=+RkZiege6oBnlTysQJEpmZ/6b0A=; b=jczL0gHy+Pa7IMBzKkMv Bl+yOl1yQG4Iob1ES3NB2l3dytXHvqXnAvC3/if/4hoK8abmbkWbkW5AJBjvHgLn K/0Xe0CTqDuHw6Mdci7mr5pKrfZ77e7u+QsqPLCrA+0RbAxEyYK3Q6Y8PvFV+Z8f upNHGLWyVZbgwNfvFvXTllQ= Received: (qmail 55388 invoked by alias); 8 Nov 2018 12:28:13 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 54508 invoked by uid 89); 8 Nov 2018 12:28:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=Hx-languages-length:692, tree-vrp.c, UD:tree-vrp.c, treevrpc X-HELO: mail-wr1-f47.google.com Received: from mail-wr1-f47.google.com (HELO mail-wr1-f47.google.com) (209.85.221.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 08 Nov 2018 12:28:11 +0000 Received: by mail-wr1-f47.google.com with SMTP id r10-v6so21041718wrv.6 for ; Thu, 08 Nov 2018 04:28:11 -0800 (PST) Received: from abulafia.quesejoda.com (128.red-88-6-116.staticip.rima-tde.net. [88.6.116.128]) by smtp.gmail.com with ESMTPSA id g5-v6sm4056960wmf.34.2018.11.08.04.28.08 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Nov 2018 04:28:08 -0800 (PST) To: gcc-patches From: Aldy Hernandez Subject: [committed] value_range::may_contain_p: Do not access extremes directly Message-ID: <48122379-2c12-d21f-c2dd-a8e5fbcf949b@redhat.com> Date: Thu, 8 Nov 2018 07:28:07 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 X-IsSubscribed: yes This is an obvious patch I will commit once testing completes. Aldy * tree-vrp.c (may_contain_p): Do not access m_min/m_max directly. diff --git a/gcc/tree-vrp.c b/gcc/tree-vrp.c index 17b0b6c6037..7af676a416d 100644 --- a/gcc/tree-vrp.c +++ b/gcc/tree-vrp.c @@ -250,10 +250,10 @@ value_range::may_contain_p (tree val) const if (m_kind == VR_ANTI_RANGE) { - int res = value_inside_range (val, m_min, m_max); + int res = value_inside_range (val, min (), max ()); return res == 0 || res == -2; } - return value_inside_range (val, m_min, m_max) != 0; + return value_inside_range (val, min (), max ()) != 0; } void