From patchwork Wed Jun 8 13:41:29 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [5/6] mtdinfo: add regioninfo/sectormap display Date: Wed, 08 Jun 2011 03:41:29 -0000 From: Artem Bityutskiy X-Patchwork-Id: 99426 Message-Id: <1307540489.31223.87.camel@localhost> To: Mike Frysinger Cc: linux-mtd@lists.infradead.org I've just pushed this little patch to make sure the code is more readable when you add your changes. Otherwise this "out:" label looks ugly. >From bc1f5c0902ce4e10f062d6e37f3f8773506e6915 Mon Sep 17 00:00:00 2001 From: Artem Bityutskiy Date: Wed, 8 Jun 2011 16:21:40 +0300 Subject: [PATCH] mtdinfo: separate out ubi information printing We are going to add some more code which prints eraseblocks map, so we need to make 'print_dev_info()' a bit smaller to keep the code readable. Signed-off-by: Artem Bityutskiy --- ubi-utils/src/mtdinfo.c | 41 +++++++++++++++++++++++------------------ 1 files changed, 23 insertions(+), 18 deletions(-) diff --git a/ubi-utils/src/mtdinfo.c b/ubi-utils/src/mtdinfo.c index 666d739..ca0ad71 100644 --- a/ubi-utils/src/mtdinfo.c +++ b/ubi-utils/src/mtdinfo.c @@ -160,6 +160,27 @@ static int translate_dev(libmtd_t libmtd, const char *node) return 0; } +static void print_ubi_info(const struct mtd_info *mtd_info, + const struct mtd_dev_info *mtd) +{ + struct ubigen_info ui; + + if (!mtd_info->sysfs_supported) { + errmsg("cannot provide UBI info, becasue sub-page size is " + "not known"); + return; + } + + ubigen_info_init(&ui, mtd->eb_size, mtd->min_io_size, mtd->subpage_size, + 0, 1, 0); + printf("Default UBI VID header offset: %d\n", ui.vid_hdr_offs); + printf("Default UBI data offset: %d\n", ui.data_offs); + printf("Default UBI LEB size: "); + ubiutils_print_bytes(ui.leb_size, 0); + printf("\n"); + printf("Maximum UBI volumes count: %d\n", ui.max_volumes); +} + static int print_dev_info(libmtd_t libmtd, const struct mtd_info *mtd_info, int mtdn) { int err; @@ -206,25 +227,9 @@ static int print_dev_info(libmtd_t libmtd, const struct mtd_info *mtd_info, int printf("Device is writable: %s\n", mtd.writable ? "true" : "false"); - if (!args.ubinfo) - goto out; - - if (!mtd_info->sysfs_supported) { - errmsg("cannot provide UBI info, becasue sub-page size is " - "not known"); - goto out; - } - - ubigen_info_init(&ui, mtd.eb_size, mtd.min_io_size, mtd.subpage_size, - 0, 1, 0); - printf("Default UBI VID header offset: %d\n", ui.vid_hdr_offs); - printf("Default UBI data offset: %d\n", ui.data_offs); - printf("Default UBI LEB size: "); - ubiutils_print_bytes(ui.leb_size, 0); - printf("\n"); - printf("Maximum UBI volumes count: %d\n", ui.max_volumes); + if (args.ubinfo) + print_ubi_info(mtd_info, &mtd); -out: printf("\n"); return 0; }