[1/2] pwm: kconfig: enable kona pwm to be built for cygnus arch

Message ID 20181107093613.26734-1-peron.clem@gmail.com
State New
Headers show
Series
  • [1/2] pwm: kconfig: enable kona pwm to be built for cygnus arch
Related show

Commit Message

Clément Péron Nov. 7, 2018, 9:36 a.m.
The Cygnus architecture use a Kona PWM. This is already present
in the device tree but can't be built actually. Hence, allow the
Kona PWM to be built for Cygnus arch.

Signed-off-by: Clément Péron <peron.clem@gmail.com>
---
 drivers/pwm/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Uwe Kleine-König Nov. 7, 2018, 4:12 p.m. | #1
On Wed, Nov 07, 2018 at 10:36:12AM +0100, Clément Péron wrote:
> The Cygnus architecture use a Kona PWM. This is already present
> in the device tree but can't be built actually. Hence, allow the
> Kona PWM to be built for Cygnus arch.
> 
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
> ---
>  drivers/pwm/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> index 763ee50ea57d..76d56fc8b1b7 100644
> --- a/drivers/pwm/Kconfig
> +++ b/drivers/pwm/Kconfig
> @@ -88,7 +88,8 @@ config PWM_BCM_IPROC
>  
>  config PWM_BCM_KONA
>  	tristate "Kona PWM support"
> -	depends on ARCH_BCM_MOBILE
> +	depends on ARCH_BCM_MOBILE || ARCH_BCM_CYGNUS
> +	default ARCH_BCM_CYGNUS

Is it possible to build this driver also on other arches? Then you might
want to consider

	depends on ARCH_BCM_MOBILE || ARCH_BCM_CYGNUS || COMPILE_TEST

Best regards
Uwe
Scott Branden Nov. 7, 2018, 4:48 p.m. | #2
On 2018-11-07 8:12 a.m., Uwe Kleine-König wrote:
> On Wed, Nov 07, 2018 at 10:36:12AM +0100, Clément Péron wrote:
>> The Cygnus architecture use a Kona PWM. This is already present
>> in the device tree but can't be built actually. Hence, allow the
>> Kona PWM to be built for Cygnus arch.
>>
>> Signed-off-by: Clément Péron <peron.clem@gmail.com>
>> ---
>>   drivers/pwm/Kconfig | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
>> index 763ee50ea57d..76d56fc8b1b7 100644
>> --- a/drivers/pwm/Kconfig
>> +++ b/drivers/pwm/Kconfig
>> @@ -88,7 +88,8 @@ config PWM_BCM_IPROC
>>   
>>   config PWM_BCM_KONA
>>   	tristate "Kona PWM support"
>> -	depends on ARCH_BCM_MOBILE
>> +	depends on ARCH_BCM_MOBILE || ARCH_BCM_CYGNUS
>> +	default ARCH_BCM_CYGNUS
> Is it possible to build this driver also on other arches? Then you might
> want to consider
>
> 	depends on ARCH_BCM_MOBILE || ARCH_BCM_CYGNUS || COMPILE_TEST
good idea to add the COMPILE_TEST just to increase compile coverage
>
> Best regards
> Uwe
>
Clément Péron Nov. 8, 2018, 10:47 a.m. | #3
Hi Uwe, Scott,

On Wed, 7 Nov 2018 at 17:48, Scott Branden <scott.branden@broadcom.com> wrote:
>
>
> On 2018-11-07 8:12 a.m., Uwe Kleine-König wrote:
> > On Wed, Nov 07, 2018 at 10:36:12AM +0100, Clément Péron wrote:
> >> The Cygnus architecture use a Kona PWM. This is already present
> >> in the device tree but can't be built actually. Hence, allow the
> >> Kona PWM to be built for Cygnus arch.
> >>
> >> Signed-off-by: Clément Péron <peron.clem@gmail.com>
> >> ---
> >>   drivers/pwm/Kconfig | 3 ++-
> >>   1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> >> index 763ee50ea57d..76d56fc8b1b7 100644
> >> --- a/drivers/pwm/Kconfig
> >> +++ b/drivers/pwm/Kconfig
> >> @@ -88,7 +88,8 @@ config PWM_BCM_IPROC
> >>
> >>   config PWM_BCM_KONA
> >>      tristate "Kona PWM support"
> >> -    depends on ARCH_BCM_MOBILE
> >> +    depends on ARCH_BCM_MOBILE || ARCH_BCM_CYGNUS
> >> +    default ARCH_BCM_CYGNUS
> > Is it possible to build this driver also on other arches? Then you might
> > want to consider
> >
> >       depends on ARCH_BCM_MOBILE || ARCH_BCM_CYGNUS || COMPILE_TEST
> good idea to add the COMPILE_TEST just to increase compile coverage

Will Do.

Thanks,
Clement

> >
> > Best regards
> > Uwe
> >
Thierry Reding Nov. 8, 2018, 12:22 p.m. | #4
On Thu, Nov 08, 2018 at 11:47:53AM +0100, Clément Péron wrote:
> Hi Uwe, Scott,
> 
> On Wed, 7 Nov 2018 at 17:48, Scott Branden <scott.branden@broadcom.com> wrote:
> >
> >
> > On 2018-11-07 8:12 a.m., Uwe Kleine-König wrote:
> > > On Wed, Nov 07, 2018 at 10:36:12AM +0100, Clément Péron wrote:
> > >> The Cygnus architecture use a Kona PWM. This is already present
> > >> in the device tree but can't be built actually. Hence, allow the
> > >> Kona PWM to be built for Cygnus arch.
> > >>
> > >> Signed-off-by: Clément Péron <peron.clem@gmail.com>
> > >> ---
> > >>   drivers/pwm/Kconfig | 3 ++-
> > >>   1 file changed, 2 insertions(+), 1 deletion(-)
> > >>
> > >> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> > >> index 763ee50ea57d..76d56fc8b1b7 100644
> > >> --- a/drivers/pwm/Kconfig
> > >> +++ b/drivers/pwm/Kconfig
> > >> @@ -88,7 +88,8 @@ config PWM_BCM_IPROC
> > >>
> > >>   config PWM_BCM_KONA
> > >>      tristate "Kona PWM support"
> > >> -    depends on ARCH_BCM_MOBILE
> > >> +    depends on ARCH_BCM_MOBILE || ARCH_BCM_CYGNUS
> > >> +    default ARCH_BCM_CYGNUS
> > > Is it possible to build this driver also on other arches? Then you might
> > > want to consider
> > >
> > >       depends on ARCH_BCM_MOBILE || ARCH_BCM_CYGNUS || COMPILE_TEST
> > good idea to add the COMPILE_TEST just to increase compile coverage
> 
> Will Do.

This is known to potentially break builds on things like UM where we
have !HAS_IOMEM. Please make sure you thoroughly build-test before you
switch on COMPILE_TEST.

Thierry
Clément Péron Nov. 9, 2018, 9:58 a.m. | #5
Hi Thierry,

On Thu, 8 Nov 2018 at 13:22, Thierry Reding <thierry.reding@gmail.com> wrote:
>
> On Thu, Nov 08, 2018 at 11:47:53AM +0100, Clément Péron wrote:
> > Hi Uwe, Scott,
> >
> > On Wed, 7 Nov 2018 at 17:48, Scott Branden <scott.branden@broadcom.com> wrote:
> > >
> > >
> > > On 2018-11-07 8:12 a.m., Uwe Kleine-König wrote:
> > > > On Wed, Nov 07, 2018 at 10:36:12AM +0100, Clément Péron wrote:
> > > >> The Cygnus architecture use a Kona PWM. This is already present
> > > >> in the device tree but can't be built actually. Hence, allow the
> > > >> Kona PWM to be built for Cygnus arch.
> > > >>
> > > >> Signed-off-by: Clément Péron <peron.clem@gmail.com>
> > > >> ---
> > > >>   drivers/pwm/Kconfig | 3 ++-
> > > >>   1 file changed, 2 insertions(+), 1 deletion(-)
> > > >>
> > > >> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> > > >> index 763ee50ea57d..76d56fc8b1b7 100644
> > > >> --- a/drivers/pwm/Kconfig
> > > >> +++ b/drivers/pwm/Kconfig
> > > >> @@ -88,7 +88,8 @@ config PWM_BCM_IPROC
> > > >>
> > > >>   config PWM_BCM_KONA
> > > >>      tristate "Kona PWM support"
> > > >> -    depends on ARCH_BCM_MOBILE
> > > >> +    depends on ARCH_BCM_MOBILE || ARCH_BCM_CYGNUS
> > > >> +    default ARCH_BCM_CYGNUS
> > > > Is it possible to build this driver also on other arches? Then you might
> > > > want to consider
> > > >
> > > >       depends on ARCH_BCM_MOBILE || ARCH_BCM_CYGNUS || COMPILE_TEST
> > > good idea to add the COMPILE_TEST just to increase compile coverage
> >
> > Will Do.
>
> This is known to potentially break builds on things like UM where we
> have !HAS_IOMEM. Please make sure you thoroughly build-test before you
> switch on COMPILE_TEST.

Thanks for the point, so something like this (but maybe it's too
protective no ?) :

config PWM_BCM_KONA
        tristate "Kona PWM support"
        depends on ARCH_BCM_MOBILE || ARCH_BCM_CYGNUS || COMPILE_TEST
        depends on COMMON_CLK && HAS_IOMEM && OF
        default ARCH_BCM_CYGNUS

Regards,
Clement


>
> Thierry
Uwe Kleine-König Nov. 9, 2018, 10:53 a.m. | #6
On Fri, Nov 09, 2018 at 10:58:41AM +0100, Clément Péron wrote:
> Hi Thierry,
> 
> On Thu, 8 Nov 2018 at 13:22, Thierry Reding <thierry.reding@gmail.com> wrote:
> >
> > On Thu, Nov 08, 2018 at 11:47:53AM +0100, Clément Péron wrote:
> > > Hi Uwe, Scott,
> > >
> > > On Wed, 7 Nov 2018 at 17:48, Scott Branden <scott.branden@broadcom.com> wrote:
> > > >
> > > >
> > > > On 2018-11-07 8:12 a.m., Uwe Kleine-König wrote:
> > > > > On Wed, Nov 07, 2018 at 10:36:12AM +0100, Clément Péron wrote:
> > > > >> The Cygnus architecture use a Kona PWM. This is already present
> > > > >> in the device tree but can't be built actually. Hence, allow the
> > > > >> Kona PWM to be built for Cygnus arch.
> > > > >>
> > > > >> Signed-off-by: Clément Péron <peron.clem@gmail.com>
> > > > >> ---
> > > > >>   drivers/pwm/Kconfig | 3 ++-
> > > > >>   1 file changed, 2 insertions(+), 1 deletion(-)
> > > > >>
> > > > >> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> > > > >> index 763ee50ea57d..76d56fc8b1b7 100644
> > > > >> --- a/drivers/pwm/Kconfig
> > > > >> +++ b/drivers/pwm/Kconfig
> > > > >> @@ -88,7 +88,8 @@ config PWM_BCM_IPROC
> > > > >>
> > > > >>   config PWM_BCM_KONA
> > > > >>      tristate "Kona PWM support"
> > > > >> -    depends on ARCH_BCM_MOBILE
> > > > >> +    depends on ARCH_BCM_MOBILE || ARCH_BCM_CYGNUS
> > > > >> +    default ARCH_BCM_CYGNUS
> > > > > Is it possible to build this driver also on other arches? Then you might
> > > > > want to consider
> > > > >
> > > > >       depends on ARCH_BCM_MOBILE || ARCH_BCM_CYGNUS || COMPILE_TEST
> > > > good idea to add the COMPILE_TEST just to increase compile coverage
> > >
> > > Will Do.
> >
> > This is known to potentially break builds on things like UM where we
> > have !HAS_IOMEM. Please make sure you thoroughly build-test before you
> > switch on COMPILE_TEST.
> 
> Thanks for the point, so something like this (but maybe it's too
> protective no ?) :
> 
> config PWM_BCM_KONA
>         tristate "Kona PWM support"
>         depends on ARCH_BCM_MOBILE || ARCH_BCM_CYGNUS || COMPILE_TEST
>         depends on COMMON_CLK && HAS_IOMEM && OF

Instead of COMMON_CLK HAVE_CLK should be good enough. Just for compile
testing the default implementations provided in include/linux/clk.h
should even be good enough in the !HAVE_CLK case.

Also OF might not be necessary, at least the driver compiles fine on
amd64 without OF.

Best regards
Uwe

Patch

diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
index 763ee50ea57d..76d56fc8b1b7 100644
--- a/drivers/pwm/Kconfig
+++ b/drivers/pwm/Kconfig
@@ -88,7 +88,8 @@  config PWM_BCM_IPROC
 
 config PWM_BCM_KONA
 	tristate "Kona PWM support"
-	depends on ARCH_BCM_MOBILE
+	depends on ARCH_BCM_MOBILE || ARCH_BCM_CYGNUS
+	default ARCH_BCM_CYGNUS
 	help
 	  Generic PWM framework driver for Broadcom Kona PWM block.