diff mbox series

[U-Boot,1/4] buildman: Only print toolchain probing with -v

Message ID 20181106230213.144851-1-sjg@chromium.org
State Accepted
Commit 40232c91d70f4f2066408cabf1afba1deb190df6
Delegated to: Simon Glass
Headers show
Series [U-Boot,1/4] buildman: Only print toolchain probing with -v | expand

Commit Message

Simon Glass Nov. 6, 2018, 11:02 p.m. UTC
At present --list-tool-chains prints a lot of information about the
toolchain-probing process. This is generally not very interesting.
Update buildman to print this only if --list-tool-chains is given
with -v.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 tools/buildman/cmdline.py | 2 +-
 tools/buildman/control.py | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Simon Glass Nov. 22, 2018, 8:21 p.m. UTC | #1
At present --list-tool-chains prints a lot of information about the
toolchain-probing process. This is generally not very interesting.
Update buildman to print this only if --list-tool-chains is given
with -v.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 tools/buildman/cmdline.py | 2 +-
 tools/buildman/control.py | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Applied to u-boot-dm/master, thanks!
diff mbox series

Patch

diff --git a/tools/buildman/cmdline.py b/tools/buildman/cmdline.py
index e493b1ac4a0..a5376e1b365 100644
--- a/tools/buildman/cmdline.py
+++ b/tools/buildman/cmdline.py
@@ -64,7 +64,7 @@  def ParseArgs():
     parser.add_option('-l', '--list-error-boards', action='store_true',
           default=False, help='Show a list of boards next to each error/warning')
     parser.add_option('--list-tool-chains', action='store_true', default=False,
-          help='List available tool chains')
+          help='List available tool chains (use -v to see probing detail)')
     parser.add_option('-n', '--dry-run', action='store_true', dest='dry_run',
           default=False, help="Do a dry run (describe actions, but do nothing)")
     parser.add_option('-N', '--no-subdirs', action='store_true', dest='no_subdirs',
diff --git a/tools/buildman/control.py b/tools/buildman/control.py
index bc0819784f8..0c0cf48d3cb 100644
--- a/tools/buildman/control.py
+++ b/tools/buildman/control.py
@@ -159,7 +159,7 @@  def DoBuildman(options, args, toolchains=None, make_func=None, boards=None,
 
     if no_toolchains:
         toolchains.GetSettings()
-        toolchains.Scan(options.list_tool_chains)
+        toolchains.Scan(options.list_tool_chains and options.verbose)
     if options.list_tool_chains:
         toolchains.List()
         print