From patchwork Tue Nov 6 23:02:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 993979 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=chromium.org Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 42qQ9g2X8Jz9sCQ for ; Wed, 7 Nov 2018 10:04:55 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 05E71C22970; Tue, 6 Nov 2018 23:03:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 3A6F1C22960; Tue, 6 Nov 2018 23:03:27 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 5078AC22967; Tue, 6 Nov 2018 23:02:20 +0000 (UTC) Received: from mail-it1-f201.google.com (mail-it1-f201.google.com [209.85.166.201]) by lists.denx.de (Postfix) with ESMTPS id BF696C2295B for ; Tue, 6 Nov 2018 23:02:19 +0000 (UTC) Received: by mail-it1-f201.google.com with SMTP id p73-v6so10659893itb.7 for ; Tue, 06 Nov 2018 15:02:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=xTQk+UU2ERAKoHRhNyABhE7u+neIpRzm3pG3UAj0PEA=; b=DMyowYo4sroTJJ5mvYN601ApCADbWrSCihZR9V/zeSF4Vvm8yMPxOdwmdRw+PZUYnr MFyl7+RKBiWRNGROAygbTOFWR/iOI0vBLzqOe5Q51iVqfRxZ6eA+5+f7ZvkvL1u2KvxM NRwezQY52DCDAmrmhE9FccVU60PMeFp48srtBLdHNxLeJa1llMUNVThkR38qP9xm5VoE yLS+Rdi1muKRiLKVPo4bJymiovo8JNuVsx0JDZDCjpP6ZYzEbeAixGQ/xNFdxorOMWvn oFabcbG6SK3VkvjZP3LPEOzYpsBQhyIfsntS+XW/T7lcO+tkmfotfeXaSATSuFmKqas2 ZqYg== X-Gm-Message-State: AGRZ1gIbdk5cDBidfNZ8ctX8Xz6rNM6q/eYWWhfIoyr3IFfAaqgumvaS +o8hXIWgPJ0kdLmHjTbhh2OZBgM= X-Google-Smtp-Source: AJdET5daTb9vl0O8u0fsqzhv0Tlyl6iWfVuIZ0iJZXoWJ/9+E0b4GROB8etIjDy1/SB5mq3AERiF9yg= X-Received: by 2002:a24:2212:: with SMTP id o18-v6mr2817310ito.24.1541545338827; Tue, 06 Nov 2018 15:02:18 -0800 (PST) Date: Tue, 6 Nov 2018 16:02:12 -0700 In-Reply-To: <20181106230213.144851-1-sjg@chromium.org> Message-Id: <20181106230213.144851-3-sjg@chromium.org> Mime-Version: 1.0 References: <20181106230213.144851-1-sjg@chromium.org> X-Mailer: git-send-email 2.19.1.930.g4563a0d9d0-goog From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini Subject: [U-Boot] [PATCH 3/4] buildman: Rename the good, better, worse variables X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" At present we don't distinguish between errors and warnings when printing the architecture summary. Rename the variables to better describe their purpose. 'Worse' at present means we got an error, so use that as the name. Signed-off-by: Simon Glass Signed-off-by: Simon Glass --- tools/buildman/builder.py | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/tools/buildman/builder.py b/tools/buildman/builder.py index fc80705a455..d9d86ef6a39 100644 --- a/tools/buildman/builder.py +++ b/tools/buildman/builder.py @@ -1196,10 +1196,10 @@ class Builder: Print(' ' + line, newline=True, colour=col) - better = [] # List of boards fixed since last commit - worse = [] # List of new broken boards since last commit - new = [] # List of boards that didn't exist last time - unknown = [] # List of boards that were not built + ok_boards = [] # List of boards fixed since last commit + err_boards = [] # List of new broken boards since last commit + new_boards = [] # List of boards that didn't exist last time + unknown_boards = [] # List of boards that were not built for target in board_dict: if target not in board_selected: @@ -1210,13 +1210,13 @@ class Builder: base_outcome = self._base_board_dict[target].rc outcome = board_dict[target] if outcome.rc == OUTCOME_UNKNOWN: - unknown.append(target) + unknown_boards.append(target) elif outcome.rc < base_outcome: - better.append(target) + ok_boards.append(target) elif outcome.rc > base_outcome: - worse.append(target) + err_boards.append(target) else: - new.append(target) + new_boards.append(target) # Get a list of errors that have appeared, and disappeared better_err, worse_err = _CalcErrorDelta(self._base_err_lines, @@ -1225,16 +1225,16 @@ class Builder: self._base_warn_line_boards, warn_lines, warn_line_boards, 'w') # Display results by arch - if (better or worse or unknown or new or worse_err or better_err - or worse_warn or better_warn): + if any((ok_boards, err_boards, unknown_boards, new_boards, worse_err, + better_err, worse_warn, better_warn)): arch_list = {} - self.AddOutcome(board_selected, arch_list, better, '', + self.AddOutcome(board_selected, arch_list, ok_boards, '', self.col.GREEN) - self.AddOutcome(board_selected, arch_list, worse, '+', + self.AddOutcome(board_selected, arch_list, err_boards, '+', self.col.RED) - self.AddOutcome(board_selected, arch_list, new, '*', self.col.BLUE) + self.AddOutcome(board_selected, arch_list, new_boards, '*', self.col.BLUE) if self._show_unknown: - self.AddOutcome(board_selected, arch_list, unknown, '?', + self.AddOutcome(board_selected, arch_list, unknown_boards, '?', self.col.MAGENTA) for arch, target_list in arch_list.iteritems(): Print('%10s: %s' % (arch, target_list))