[ovs-dev,2/2] vswitchd: Update documentation for legacy_l3 type packets

Message ID 1541543066-4355-2-git-send-email-gvrose8192@gmail.com
State Accepted
Headers show
Series
  • [ovs-dev,1/2] gre: Remove dead ipgre code
Related show

Commit Message

Gregory Rose Nov. 6, 2018, 10:24 p.m.
The documentation needs to specify that for GRE tunnels there is no
support for legacy_l3 type packets in the kernel datapath.

Signed-off-by: Greg Rose <gvrose8192@gmail.com>
---
 vswitchd/vswitch.xml | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

William Tu Nov. 6, 2018, 11:03 p.m. | #1
On Tue, Nov 6, 2018 at 2:24 PM Greg Rose <gvrose8192@gmail.com> wrote:
>
> The documentation needs to specify that for GRE tunnels there is no
> support for legacy_l3 type packets in the kernel datapath.
>
> Signed-off-by: Greg Rose <gvrose8192@gmail.com>
> ---
LGTM.
Acked-by: William Tu <u9012063@gmail.com>
Ben Pfaff Nov. 9, 2018, 5:31 p.m. | #2
On Tue, Nov 06, 2018 at 03:03:32PM -0800, William Tu wrote:
> On Tue, Nov 6, 2018 at 2:24 PM Greg Rose <gvrose8192@gmail.com> wrote:
> >
> > The documentation needs to specify that for GRE tunnels there is no
> > support for legacy_l3 type packets in the kernel datapath.
> >
> > Signed-off-by: Greg Rose <gvrose8192@gmail.com>
> > ---
> LGTM.
> Acked-by: William Tu <u9012063@gmail.com>

Thanks Greg and William, I applied this series to master.

Patch

diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
index efa1ef8..b0b42e0 100644
--- a/vswitchd/vswitch.xml
+++ b/vswitchd/vswitch.xml
@@ -2700,6 +2700,12 @@ 
               OpenFlow controllers that expect this behavior.
             </li>
             <li>
+              The <code>legacy_l3</code> option is only available via the
+              user space datapath.  The OVS kernel datapath does not support
+              devices of type ARPHRD_IPGRE which is the requirement for
+              <code>legacy_l3</code> type packets.
+            </li>
+            <li>
               If this option is <code>ptap</code>, the tunnel sends and
               receives any kind of packet.  Open vSwitch represents packets in
               the tunnel using the <code>packet_type</code> mechanism