From patchwork Wed Jun 8 08:24:45 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 99380 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 8AE02B6FEB for ; Wed, 8 Jun 2011 18:50:44 +1000 (EST) Received: from localhost ([::1]:37741 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUETJ-00050M-5h for incoming@patchwork.ozlabs.org; Wed, 08 Jun 2011 04:50:41 -0400 Received: from eggs.gnu.org ([140.186.70.92]:34182) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUE4l-00088n-1R for qemu-devel@nongnu.org; Wed, 08 Jun 2011 04:25:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QUE4j-0007kJ-E8 for qemu-devel@nongnu.org; Wed, 08 Jun 2011 04:25:18 -0400 Received: from mtagate2.uk.ibm.com ([194.196.100.162]:38790) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUE4i-0007hA-R9 for qemu-devel@nongnu.org; Wed, 08 Jun 2011 04:25:17 -0400 Received: from d06nrmr1507.portsmouth.uk.ibm.com (d06nrmr1507.portsmouth.uk.ibm.com [9.149.38.233]) by mtagate2.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p588P5do010748 for ; Wed, 8 Jun 2011 08:25:05 GMT Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by d06nrmr1507.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p588P2rA2302052 for ; Wed, 8 Jun 2011 09:25:04 +0100 Received: from d06av07.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p588P1XA013788 for ; Wed, 8 Jun 2011 02:25:02 -0600 Received: from stefanha-thinkpad.ibm.com (huv01711.de.ibm.com [9.145.191.199]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p588OxoJ013679; Wed, 8 Jun 2011 02:25:01 -0600 From: Stefan Hajnoczi To: Date: Wed, 8 Jun 2011 09:24:45 +0100 Message-Id: <1307521488-6066-4-git-send-email-stefanha@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.4.4 In-Reply-To: <1307521488-6066-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1307521488-6066-1-git-send-email-stefanha@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Received-From: 194.196.100.162 Cc: Alexander Graf , Stefan Hajnoczi Subject: [Qemu-devel] [PATCH 3/6] slirp: fix guestfwd id X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Alexander Graf When using -net user,guestfwd=... Qemu immediately complains about the id being in invalid format. This is because we pass in an id that contains a colon, while the id restrictions don't allow colons. This patch changes the colon into a dot, making guestfwd work again. Signed-off-by: Alexander Graf Signed-off-by: Stefan Hajnoczi --- net/slirp.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index e387a11..e057a14 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -614,7 +614,7 @@ static int slirp_guestfwd(SlirpState *s, const char *config_str, } fwd = qemu_malloc(sizeof(struct GuestFwd)); - snprintf(buf, sizeof(buf), "guestfwd.tcp:%d", port); + snprintf(buf, sizeof(buf), "guestfwd.tcp.%d", port); fwd->hd = qemu_chr_open(buf, p, NULL); if (!fwd->hd) { error_report("could not open guest forwarding device '%s'", buf);