Patchwork net: ifdef NET_TX_SOFTIRQ, NET_RX_SOFTIRQ

login
register
mail settings
Submitter Alexey Dobriyan
Date Nov. 21, 2008, 4:58 a.m.
Message ID <20081121045859.GA5625@x200.localdomain>
Download mbox | patch
Permalink /patch/9937/
State Rejected
Delegated to: David Miller
Headers show

Comments

Alexey Dobriyan - Nov. 21, 2008, 4:58 a.m.
Now that number of softirqs actually matters (see NR_SOFTIRQS), it makes
sense to not add networking ones when not needed.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 include/linux/interrupt.h |    2 ++
 1 file changed, 2 insertions(+)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Nov. 21, 2008, 5:02 a.m.
From: Alexey Dobriyan <adobriyan@gmail.com>
Date: Fri, 21 Nov 2008 07:58:59 +0300

> Now that number of softirqs actually matters (see NR_SOFTIRQS), it makes
> sense to not add networking ones when not needed.
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>

I'd rather not do this for now.

Thanks for the patch, though.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- a/include/linux/interrupt.h
+++ b/include/linux/interrupt.h
@@ -246,8 +246,10 @@  enum
 {
 	HI_SOFTIRQ=0,
 	TIMER_SOFTIRQ,
+#ifdef CONFIG_NET
 	NET_TX_SOFTIRQ,
 	NET_RX_SOFTIRQ,
+#endif
 	BLOCK_SOFTIRQ,
 	TASKLET_SOFTIRQ,
 	SCHED_SOFTIRQ,