[v1,13/15] pinctrl: baytrail: Code formatting fixes

Message ID 20181106110434.49221-13-andriy.shevchenko@linux.intel.com
State New
Headers show
Series
  • [v1,01/15] pinctrl: cedarfork: Get rid of unneeded ->probe() stub
Related show

Commit Message

Andy Shevchenko Nov. 6, 2018, 11:04 a.m.
Replace '{ }' and remove comma from terminator line to be consistent with
the rest Intel SoC pin control drivers.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/pinctrl/intel/pinctrl-baytrail.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Mika Westerberg Nov. 6, 2018, 1:52 p.m. | #1
On Tue, Nov 06, 2018 at 01:04:32PM +0200, Andy Shevchenko wrote:
> Replace '{ }' and remove comma from terminator line to be consistent with
> the rest Intel SoC pin control drivers.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/pinctrl/intel/pinctrl-baytrail.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c
> index 6d1a43c0c251..44decdc9f07c 100644
> --- a/drivers/pinctrl/intel/pinctrl-baytrail.c
> +++ b/drivers/pinctrl/intel/pinctrl-baytrail.c
> @@ -705,7 +705,7 @@ static const struct byt_pinctrl_soc_data *byt_soc_data[] = {
>  	&byt_score_soc_data,
>  	&byt_sus_soc_data,
>  	&byt_ncore_soc_data,
> -	NULL,
> +	NULL

I prefer to have trailing "," but as discussed offline there is point
not having it after the terminator (mainly that compiler can catch if
someone adds an entry after it). So please update the changelog
accordingly.

Thanks!
Andy Shevchenko Nov. 6, 2018, 2:28 p.m. | #2
On Tue, Nov 06, 2018 at 03:52:38PM +0200, Mika Westerberg wrote:
> On Tue, Nov 06, 2018 at 01:04:32PM +0200, Andy Shevchenko wrote:
> > Replace '{ }' and remove comma from terminator line to be consistent with
> > the rest Intel SoC pin control drivers.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  drivers/pinctrl/intel/pinctrl-baytrail.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c
> > index 6d1a43c0c251..44decdc9f07c 100644
> > --- a/drivers/pinctrl/intel/pinctrl-baytrail.c
> > +++ b/drivers/pinctrl/intel/pinctrl-baytrail.c
> > @@ -705,7 +705,7 @@ static const struct byt_pinctrl_soc_data *byt_soc_data[] = {
> >  	&byt_score_soc_data,
> >  	&byt_sus_soc_data,
> >  	&byt_ncore_soc_data,
> > -	NULL,
> > +	NULL
> 
> I prefer to have trailing "," but as discussed offline there is point
> not having it after the terminator (mainly that compiler can catch if
> someone adds an entry after it). So please update the changelog
> accordingly.

Will do, thanks!

Patch

diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c
index 6d1a43c0c251..44decdc9f07c 100644
--- a/drivers/pinctrl/intel/pinctrl-baytrail.c
+++ b/drivers/pinctrl/intel/pinctrl-baytrail.c
@@ -705,7 +705,7 @@  static const struct byt_pinctrl_soc_data *byt_soc_data[] = {
 	&byt_score_soc_data,
 	&byt_sus_soc_data,
 	&byt_ncore_soc_data,
-	NULL,
+	NULL
 };
 
 static struct byt_community *byt_get_community(struct byt_gpio *vg,
@@ -1774,7 +1774,7 @@  static int byt_set_soc_data(struct byt_gpio *vg,
 static const struct acpi_device_id byt_gpio_acpi_match[] = {
 	{ "INT33B2", (kernel_ulong_t)byt_soc_data },
 	{ "INT33FC", (kernel_ulong_t)byt_soc_data },
-	{ }
+	{}
 };
 
 static int byt_pinctrl_probe(struct platform_device *pdev)