[v2] package/libid3tag: add .pc file and install to staging hook

Message ID 20181105182701.5646-1-joerg.krause@embedded.rocks
State Accepted
Headers show
Series
  • [v2] package/libid3tag: add .pc file and install to staging hook
Related show

Commit Message

Jörg Krause Nov. 5, 2018, 6:27 p.m.
The MPD project dropped autotools support in version 0.21.x in favor of
meson. While adapting the package to the meson build infrastructure, the
recognition of libid3tag failed, as only pkg-config is used to detect
the library. Note, that the version bump of the mpd package to 0.21.x is
not submitted, yet.

To help finding the build system to detect libid3tag with pkg-config
properly, add a .pc file and install it to staging.

Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>
---
v1 -> v2:
 - add commit message (Thomas)
---
 package/libid3tag/id3tag.pc    | 11 +++++++++++
 package/libid3tag/libid3tag.mk |  7 +++++++
 2 files changed, 18 insertions(+)
 create mode 100644 package/libid3tag/id3tag.pc

Comments

Arnout Vandecappelle (Essensium/Mind) Nov. 27, 2018, 10:34 p.m. | #1
On 05/11/2018 19:27, Jörg Krause wrote:
> The MPD project dropped autotools support in version 0.21.x in favor of
> meson. While adapting the package to the meson build infrastructure, the
> recognition of libid3tag failed, as only pkg-config is used to detect
> the library. Note, that the version bump of the mpd package to 0.21.x is
> not submitted, yet.
> 
> To help finding the build system to detect libid3tag with pkg-config
> properly, add a .pc file and install it to staging.
> 
> Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>

 I've added a note that Fedora and Debian do exactly the same (they add their
own .pc file) and applied to next, thanks.

 Regards,
 Arnout

Patch

diff --git a/package/libid3tag/id3tag.pc b/package/libid3tag/id3tag.pc
new file mode 100644
index 0000000000..845eb3276b
--- /dev/null
+++ b/package/libid3tag/id3tag.pc
@@ -0,0 +1,11 @@ 
+prefix=/usr
+exec_prefix=${prefix}
+libdir=${exec_prefix}/lib
+includedir=${prefix}/include
+
+Name: id3tag
+Description: ID3 tag reading library
+Version: 0.15.1b
+Requires:
+Libs: -L${libdir} -lid3tag
+Cflags: -I${includedir}
diff --git a/package/libid3tag/libid3tag.mk b/package/libid3tag/libid3tag.mk
index 951ae09c77..24342186cc 100644
--- a/package/libid3tag/libid3tag.mk
+++ b/package/libid3tag/libid3tag.mk
@@ -12,4 +12,11 @@  LIBID3TAG_INSTALL_STAGING = YES
 LIBID3TAG_DEPENDENCIES = zlib
 LIBID3TAG_LIBTOOL_PATCH = NO
 
+define LIBID3TAG_INSTALL_STAGING_PC
+	$(INSTALL) -D package/libid3tag/id3tag.pc \
+		$(STAGING_DIR)/usr/lib/pkgconfig/id3tag.pc
+endef
+
+LIBID3TAG_POST_INSTALL_STAGING_HOOKS += LIBID3TAG_INSTALL_STAGING_PC
+
 $(eval $(autotools-package))