| Message ID | 1307478974-32727-1-git-send-email-peterhuewe@gmx.de |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
Am Dienstag 07 Juni 2011, 22:36:14 schrieb Peter Huewe: > This patch replaces the code for getting an number from a > userspace buffer by a simple call to kstrou8_from_user. > This makes it easier to read and less error prone. > > Since the old buffer was only 10 bytes long and the value is masked by a > nibble-mask anyway, we don't need to use kstrtoul but rather kstrtou8. > > Kernel Version: v3.0-rc2 > > Signed-off-by: Peter Huewe <peterhuewe@gmx.de> Any updates on this one? Still applies to the latest linus' tree Thanks, Peter -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, Aug 28, 2011 at 09:52:31PM +0200, Peter Hüwe wrote: > Am Dienstag 07 Juni 2011, 22:36:14 schrieb Peter Huewe: > > This patch replaces the code for getting an number from a > > userspace buffer by a simple call to kstrou8_from_user. > > This makes it easier to read and less error prone. > > > > Since the old buffer was only 10 bytes long and the value is masked by a > > nibble-mask anyway, we don't need to use kstrtoul but rather kstrtou8. > > > > Kernel Version: v3.0-rc2 > > > > Signed-off-by: Peter Huewe <peterhuewe@gmx.de> > > Any updates on this one? > Still applies to the latest linus' tree I merged it to wireless-next yesterday. Thanks for the reminder! John
diff --git a/net/mac80211/debugfs.c b/net/mac80211/debugfs.c index 186e02f..267ed45 100644 --- a/net/mac80211/debugfs.c +++ b/net/mac80211/debugfs.c @@ -195,20 +195,12 @@ static ssize_t uapsd_queues_write(struct file *file, size_t count, loff_t *ppos) { struct ieee80211_local *local = file->private_data; - unsigned long val; - char buf[10]; - size_t len; + u8 val; int ret; - len = min(count, sizeof(buf) - 1); - if (copy_from_user(buf, user_buf, len)) - return -EFAULT; - buf[len] = '\0'; - - ret = strict_strtoul(buf, 0, &val); - + ret = kstrtou8_from_user(user_buf, count, 0, &val); if (ret) - return -EINVAL; + return ret; if (val & ~IEEE80211_WMM_IE_STA_QOSINFO_AC_MASK) return -ERANGE;
This patch replaces the code for getting an number from a userspace buffer by a simple call to kstrou8_from_user. This makes it easier to read and less error prone. Since the old buffer was only 10 bytes long and the value is masked by a nibble-mask anyway, we don't need to use kstrtoul but rather kstrtou8. Kernel Version: v3.0-rc2 Signed-off-by: Peter Huewe <peterhuewe@gmx.de> --- net/mac80211/debugfs.c | 14 +++----------- 1 files changed, 3 insertions(+), 11 deletions(-)