From patchwork Mon Nov 5 09:32:34 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Ni X-Patchwork-Id: 992966 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-tegra-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nvidia.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=nvidia.com header.i=@nvidia.com header.b="Zvc+a3rM"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42pSCd0gNNz9sCh for ; Mon, 5 Nov 2018 20:33:17 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729035AbeKESwD (ORCPT ); Mon, 5 Nov 2018 13:52:03 -0500 Received: from hqemgate16.nvidia.com ([216.228.121.65]:4941 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728971AbeKESwC (ORCPT ); Mon, 5 Nov 2018 13:52:02 -0500 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 05 Nov 2018 01:33:20 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Mon, 05 Nov 2018 01:33:12 -0800 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Mon, 05 Nov 2018 01:33:12 -0800 Received: from HQMAIL107.nvidia.com (172.20.187.13) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 5 Nov 2018 09:33:12 +0000 Received: from hqnvemgw02.nvidia.com (172.16.227.111) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Mon, 5 Nov 2018 09:33:12 +0000 Received: from niwei-ubuntu.nvidia.com (Not Verified[10.19.225.182]) by hqnvemgw02.nvidia.com with Trustwave SEG (v7, 5, 8, 10121) id ; Mon, 05 Nov 2018 01:33:12 -0800 From: Wei Ni To: , , CC: , , , Wei Ni Subject: [PATCH v1 4/4] thermal: tegra: fix coverity defect Date: Mon, 5 Nov 2018 17:32:34 +0800 Message-ID: <1541410354-19090-5-git-send-email-wni@nvidia.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1541410354-19090-1-git-send-email-wni@nvidia.com> References: <1541410354-19090-1-git-send-email-wni@nvidia.com> X-NVConfidentiality: public MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1541410401; bh=Q5lgwwI271wuGc9mM0mSl/fwyPck+Gs4fTtsLWe1/L4=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:X-NVConfidentiality:MIME-Version: Content-Type; b=Zvc+a3rMj0JGdW8jMbfYV9cuCTRbNaRsVXIZm8OmTVpdN/iKCkZ6uYQ3zamtqunJe SXpaARrVzKHfp25/b+5sW1hkqPd5O2poTIv7zijyDY24vEkTeEBZujpQNil6taUwBk TTl4kf2ex10OQtS82QErTzAQQFlgHdz6Q+RLunUQLxmm4SwNQxJsvtt4qw54SX74FB DBKEktTD/xQDQtHyDkp9lMYG99humDfilDvtBogGor2Q+e9cI6rY6ZWEX0KURneJ13 yyGRfYcXPw9f5vgvCWDV1xbDDjDdyE64+dbreFUXVYEQzfpxpl9XsRNfRl2w8A0UhG qq3wNiBdpyeMA== Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org Fix dereference dev before null check. Signed-off-by: Wei Ni --- drivers/thermal/tegra/soctherm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c index 3042837364e8..96527df91f2a 100644 --- a/drivers/thermal/tegra/soctherm.c +++ b/drivers/thermal/tegra/soctherm.c @@ -397,7 +397,7 @@ static int throttrip_program(struct device *dev, struct soctherm_throt_cfg *stc, int trip_temp) { - struct tegra_soctherm *ts = dev_get_drvdata(dev); + struct tegra_soctherm *ts; int temp, cpu_throt, gpu_throt; unsigned int throt; u32 r, reg_off; @@ -405,6 +405,8 @@ static int throttrip_program(struct device *dev, if (!sg || !stc || !stc->init) return -EINVAL; + ts = dev_get_drvdata(dev); + temp = enforce_temp_range(dev, trip_temp) / ts->soc->thresh_grain; /* Hardcode LIGHT on LEVEL1 and HEAVY on LEVEL2 */