| Message ID | 1541387759-2336-1-git-send-email-shunyong.yang@hxt-semitech.com |
|---|---|
| State | Superseded |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
| Series | PCI: Add HXT vendor ID and ACS quirk | expand |
On 11/4/2018 7:15 PM, Shunyong Yang wrote: > Add the HXT vendor ID to pci_ids.h and use it in quirks. As the > design of HXT SD4800 ACS feature is the same as QCOM QDF2xxx, > pci_quirk_qcom_rp_acs() is reused for SD4800 quirk. > > Cc: Joey Zheng<yu.zheng@hxt-semitech.com> > Signed-off-by: Shunyong Yang<shunyong.yang@hxt-semitech.com> There is also a couple of hotplug quirks for QDF2400. You should probably take care of those as well. Assuming your PCI IDs are correct: Reviewed-by: Sinan Kaya <okaya@kernel.org>
Hi, Sinan, On 2018/11/6 7:12, Sinan Kaya wrote: > On 11/4/2018 7:15 PM, Shunyong Yang wrote: >> Add the HXT vendor ID to pci_ids.h and use it in quirks. As the >> design of HXT SD4800 ACS feature is the same as QCOM QDF2xxx, >> pci_quirk_qcom_rp_acs() is reused for SD4800 quirk. >> >> Cc: Joey Zheng<yu.zheng@hxt-semitech.com> >> Signed-off-by: Shunyong Yang<shunyong.yang@hxt-semitech.com> > > There is also a couple of hotplug quirks for QDF2400. You should > probably take care of those as well. > > Assuming your PCI IDs are correct: > > Reviewed-by: Sinan Kaya <okaya@kernel.org> > Thanks for your review and information. I will check the changes. Shunyong.
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 4700d24e5d55..1e00ef6a88f4 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -4495,6 +4495,8 @@ static int pci_quirk_mf_endpoint_acs(struct pci_dev *dev, u16 acs_flags) /* QCOM QDF2xxx root ports */ { PCI_VENDOR_ID_QCOM, 0x0400, pci_quirk_qcom_rp_acs }, { PCI_VENDOR_ID_QCOM, 0x0401, pci_quirk_qcom_rp_acs }, + /* HXT SD4800 root ports. The ACS design is same as QCOM QDF2xxx */ + { PCI_VENDOR_ID_HXT, 0x0401, pci_quirk_qcom_rp_acs }, /* Intel PCH root ports */ { PCI_VENDOR_ID_INTEL, PCI_ANY_ID, pci_quirk_intel_pch_acs }, { PCI_VENDOR_ID_INTEL, PCI_ANY_ID, pci_quirk_intel_spt_pch_acs }, diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index f4e278493f5b..e3d7efb1442f 100644 --- a/include/linux/pci_ids.h +++ b/include/linux/pci_ids.h @@ -2559,6 +2559,8 @@ #define PCI_VENDOR_ID_AMAZON 0x1d0f +#define PCI_VENDOR_ID_HXT 0x1dbf + #define PCI_VENDOR_ID_TEKRAM 0x1de1 #define PCI_DEVICE_ID_TEKRAM_DC290 0xdc29
Add the HXT vendor ID to pci_ids.h and use it in quirks. As the design of HXT SD4800 ACS feature is the same as QCOM QDF2xxx, pci_quirk_qcom_rp_acs() is reused for SD4800 quirk. Cc: Joey Zheng <yu.zheng@hxt-semitech.com> Signed-off-by: Shunyong Yang <shunyong.yang@hxt-semitech.com> --- drivers/pci/quirks.c | 2 ++ include/linux/pci_ids.h | 2 ++ 2 files changed, 4 insertions(+)